Bug 68570 - Remove Widget::beforeMouseDown and Widget::afterMouseDown
Summary: Remove Widget::beforeMouseDown and Widget::afterMouseDown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 14:36 PDT by Anders Carlsson
Modified: 2011-09-22 13:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.89 KB, patch)
2011-09-21 14:40 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-09-21 14:36:59 PDT
Remove Widget::beforeMouseDown and Widget::afterMouseDown
Comment 1 Anders Carlsson 2011-09-21 14:40:48 PDT
Created attachment 108235 [details]
Patch
Comment 2 Anders Carlsson 2011-09-21 15:19:01 PDT
Committed r95673: <http://trac.webkit.org/changeset/95673>
Comment 3 Darin Adler 2011-09-21 15:21:07 PDT
I think these might have still been relevant with WebKit1 and WebKit plug-ins.
Comment 4 Anders Carlsson 2011-09-21 15:34:13 PDT
(In reply to comment #3)
> I think these might have still been relevant with WebKit1 and WebKit plug-ins.

I'm not sure if this code path is taken for WebKit plug-ins but I'll double check. We can always fix that by surrounding the call with RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates()
Comment 5 Ryosuke Niwa 2011-09-22 11:52:58 PDT
Apparently this patch caused hundreds of tests to fail on Leopard / Snow Leopard WebKit1.

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/33283
Comment 6 Ryosuke Niwa 2011-09-22 11:54:55 PDT
Roll out the patch in http://trac.webkit.org/changeset/95743 after IRC discussion with andersca.
Comment 7 Anders Carlsson 2011-09-22 13:36:33 PDT
Committed r95749: <http://trac.webkit.org/changeset/95749>