RESOLVED FIXED 68570
Remove Widget::beforeMouseDown and Widget::afterMouseDown 
https://bugs.webkit.org/show_bug.cgi?id=68570
Summary Remove Widget::beforeMouseDown and Widget::afterMouseDown
Anders Carlsson
Reported 2011-09-21 14:36:59 PDT
Remove Widget::beforeMouseDown and Widget::afterMouseDown
Attachments
Patch (4.89 KB, patch)
2011-09-21 14:40 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-09-21 14:40:48 PDT
Created attachment 108235 [details] Patch
Anders Carlsson
Comment 2 2011-09-21 15:19:01 PDT
Committed r95673: <http://trac.webkit.org/changeset/95673>
Darin Adler
Comment 3 2011-09-21 15:21:07 PDT
I think these might have still been relevant with WebKit1 and WebKit plug-ins.
Anders Carlsson
Comment 4 2011-09-21 15:34:13 PDT
(In reply to comment #3) > I think these might have still been relevant with WebKit1 and WebKit plug-ins. I'm not sure if this code path is taken for WebKit plug-ins but I'll double check. We can always fix that by surrounding the call with RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates()
Ryosuke Niwa
Comment 5 2011-09-22 11:52:58 PDT
Apparently this patch caused hundreds of tests to fail on Leopard / Snow Leopard WebKit1. http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/33283
Ryosuke Niwa
Comment 6 2011-09-22 11:54:55 PDT
Roll out the patch in http://trac.webkit.org/changeset/95743 after IRC discussion with andersca.
Anders Carlsson
Comment 7 2011-09-22 13:36:33 PDT
Committed r95749: <http://trac.webkit.org/changeset/95749>
Note You need to log in before you can comment on or make changes to this bug.