Bug 68562 - Pagination struts don't update properly when collapsing margin estimates are wrong.
Summary: Pagination struts don't update properly when collapsing margin estimates are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 12:53 PDT by Dave Hyatt
Modified: 2011-09-21 14:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (56.08 KB, patch)
2011-09-21 13:05 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (55.52 KB, patch)
2011-09-21 13:08 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (55.51 KB, patch)
2011-09-21 13:18 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff
Patch (49.49 KB, patch)
2011-09-21 14:45 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-09-21 12:53:48 PDT
Pagination struts don't update properly when collapsing margin estimates are wrong. It's hard to see this problem without a very small "page" size, so regions are what brought it to my attention.

Basically if your logical top estimation is wrong, you need to do a relayout prior to applying final pagination adjustments. In other words, you have to do a 3-pass layout instead of a 2-pass layout, since fixing up your collapsed margin or clearance position may cause you to then propagate new pagination strut information.
Comment 1 Dave Hyatt 2011-09-21 13:00:16 PDT
Fixing this bug will cause some regions tests to fail. These tests were only passing through sheer luck, though, and the bug exposed by this is already present in regions.
Comment 2 Dave Hyatt 2011-09-21 13:05:55 PDT
Created attachment 108216 [details]
Patch
Comment 3 Dave Hyatt 2011-09-21 13:08:27 PDT
Created attachment 108217 [details]
Patch
Comment 4 WebKit Review Bot 2011-09-21 13:09:22 PDT
Attachment 108216 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/RenderBlock.h:824:  The parameter name "marginInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/RenderBlock.cpp:6311:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:6320:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2011-09-21 13:10:44 PDT
Attachment 108217 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/RenderBlock.h:824:  The parameter name "marginInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/RenderBlock.cpp:6311:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:6320:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dave Hyatt 2011-09-21 13:18:57 PDT
Created attachment 108218 [details]
Patch
Comment 7 Dave Hyatt 2011-09-21 14:45:11 PDT
Created attachment 108236 [details]
Patch
Comment 8 Dave Hyatt 2011-09-21 14:55:24 PDT
Landed in r95670.