Bug 68557 - Replace jsFunctionVPtr compares with a type check on the Structure.
Summary: Replace jsFunctionVPtr compares with a type check on the Structure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 68603 68606
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-21 12:16 PDT by Gavin Barraclough
Modified: 2011-09-22 04:01 PDT (History)
1 user (show)

See Also:


Attachments
Fix (20.93 KB, patch)
2011-09-21 12:18 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-09-21 12:16:26 PDT
This will permit calls to still optimize to subclasses of JSFunction that have the correct type (but a different C++ vptr).
Comment 1 Gavin Barraclough 2011-09-21 12:18:57 PDT
Created attachment 108205 [details]
Fix

No perf impact.
Comment 2 WebKit Review Bot 2011-09-21 12:22:02 PDT
Attachment 108205 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/JSObject.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-09-21 12:58:45 PDT
Fixed in r95666