Bug 68547 – [WK2][GTK]App changes - Implementation of TextChecker

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit2

[Ravi Phaneendra Kasibhatla]

Created attachment 108185 [details]
App changes for TextChecker 

The bug captures the app changes required for verifying the TextChecker feature for WebKit2 GTK port.

[WebKit Review Bot]

Attachment 108185 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1

Last 3072 characters of output:
claration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:738:  Declaration has space between * and variable name in EnchantDict* dict  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:750:  Declaration has space between * and variable name in BrowserWindow* window  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:751:  Declaration has space between * and variable name in GSList* dicts  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:756:  Declaration has space between * and variable name in char* string  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:758:  Declaration has space between * and variable name in PangoLanguage* language  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:759:  Declaration has space between * and variable name in PangoLogAttr* attrs  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:782:  Declaration has space between * and variable name in gchar* cstart  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:784:  Declaration has space between * and variable name in gchar* word  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:789:  Declaration has space between * and variable name in EnchantDict* dict  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:813:  Declaration has space between * and variable name in BrowserWindow* window  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:814:  Declaration has space between * and variable name in GSList* dicts  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:820:  Declaration has space between * and variable name in char* string  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:827:  Declaration has space between * and variable name in EnchantDict* dict  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:852:  Declaration has space between * and variable name in BrowserWindow* window  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:853:  Declaration has space between * and variable name in GSList* dicts  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:858:  Declaration has space between * and variable name in char* string  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:862:  Declaration has space between * and variable name in EnchantDict* dict  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:872:  Declaration has space between * and variable name in BrowserWindow* window  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:873:  Declaration has space between * and variable name in GSList* dicts  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:878:  Declaration has space between * and variable name in char* string  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserWindow.c:882:  Declaration has space between * and variable name in EnchantDict* dict  [whitespace/declaration] [3]
Total errors found: 32 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 108185 [details]
App changes for TextChecker 

Attachment 108185 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9765853

[Martin Robinson]

I think perhaps this is already implemented with API backing it. :(

*** This bug has been marked as a duplicate of bug 90268 ***

[Eric Seidel (no email)]

Comment on attachment 108185 [details]
App changes for TextChecker 

Cleared review? from attachment 108185 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).