Bug 68537 - Web Inspector: add minimal error handling to the DOM breakpoints.
Summary: Web Inspector: add minimal error handling to the DOM breakpoints.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 08:25 PDT by Pavel Feldman
Modified: 2011-09-21 08:39 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2011-09-21 08:27 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-09-21 08:25:50 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-09-21 08:27:32 PDT 
Created attachment 108166 [details]
Patch
Comment 2 Yury Semikhatsky 2011-09-21 08:31:55 PDT 
Comment on attachment 108166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108166&action=review

> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:189
> +    *errorString = "Unknown DOM breakpoint type: " + typeString;

Use makeString instead?
Comment 3 Pavel Feldman 2011-09-21 08:39:03 PDT 
Committed r95634: <http://trac.webkit.org/changeset/95634>