Bug 68530 - Web Inspector: introduce Page.enable and Page.disable
Summary: Web Inspector: introduce Page.enable and Page.disable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 07:03 PDT by Pavel Feldman
Modified: 2011-09-21 09:12 PDT (History)
10 users (show)

See Also:


Attachments
Patch (23.51 KB, patch)
2011-09-21 07:05 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-09-21 07:03:28 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-09-21 07:05:23 PDT
Created attachment 108151 [details]
Patch
Comment 2 Yury Semikhatsky 2011-09-21 09:01:07 PDT
Comment on attachment 108151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108151&action=review

> Source/WebCore/ChangeLog:5
> +

Is it possible to describe this change in a few words here?

> Source/WebCore/inspector/Inspector.json:147
> +                    { "name": "newWindow", "optional": true, "type": "boolean", "description": "If true, opens given URL in a new window or tab.", "hidden": true }

Let's remove this method altogether since the same effect can be reached using the evaluate() command and there is no much sense in having a dedicated command for this functionality.

> Source/WebCore/inspector/Inspector.json:548
> +                "description": "Always send extra HTTP headers with the requests from this page.",

style: should be something like "Specifies whether to always send..." for consistency with other descriptions.

> Source/WebCore/inspector/InspectorController.cpp:355
> +    m_pageAgent->restore();

Shouldn't this call go before m_domAgent->restore?
Comment 3 Pavel Feldman 2011-09-21 09:12:58 PDT
Committed r95636: <http://trac.webkit.org/changeset/95636>