Bug 68522 – WebSocket: Split Hixie76 length-prefixed frames aren't handled correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Philippe Normand]

Diff:

--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-expected.txt 
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-actual.txt 
@@ -3,9 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 WebSocket is open
-received:done
 WebSocket is closed
-PASS errorCount is 255
+FAIL errorCount should be 255. Was 241.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Yuta Kitamura]

I was digging this issue these days, and this turned out to be a real bug in WebSocketChannel.

This happens only when the following conditions are met:
- Hixie76 binary (length-prefixed) frame is sent from the server.
- The client receives only the first byte of the frame, and the remaining bytes later (i.e. split into two different WebSocketChannel::didReceiveData() calls).

GTK tests have reproduced this situation (somewhat) reliably.

I will upload a patch that fixes this problem shortly.

[Yuta Kitamura]

Updating bug summary to reflect the actual problem

[Yuta Kitamura]

Created attachment 116746 [details]
Patch

[Martin Robinson]

(In reply to comment #3)
> Created an attachment (id=116746) [details]
> Patch

Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file?

[Kent Tamura]

Comment on attachment 116746 [details]
Patch

Looks ok.

[Yuta Kitamura]

Thanks.

[WebKit Review Bot]

Comment on attachment 116746 [details]
Patch

Clearing flags on attachment: 116746

Committed r101326: <http://trac.webkit.org/changeset/101326>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=116746) [details] [details]
> > Patch
> 
> Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file?

I unskipped it in r101338.

[Yuta Kitamura]

Thanks!