Bug 68507 - Syntax error in media/audio-delete-while-step-button-clicked.html
Summary: Syntax error in media/audio-delete-while-step-button-clicked.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 01:05 PDT by Philippe Normand
Modified: 2011-09-21 07:48 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.78 KB, patch)
2011-09-21 01:07 PDT, Philippe Normand
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-09-21 01:05:09 PDT
--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/audio-delete-while-step-button-clicked-expected.txt 
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/audio-delete-while-step-button-clicked-actual.txt 
@@ -1,13 +1,8 @@
+CONSOLE MESSAGE: line 58: SyntaxError: Expected token '{'
+CONSOLE MESSAGE: line 86: ReferenceError: Can't find variable: start
+FAIL: Timed out waiting for notifyDone to be called
 This tests that events don't continue to target a step button if the media element is deleted while mouse down on button. 
  
 
 
-clicking step forward
-clicking step forward
-timeupdate
 
-deleting audio element
-
-clicking button
-button click!
-

http://trac.webkit.org/changeset/95133 is the culprit, the fix is trivial though :)
Comment 1 Philippe Normand 2011-09-21 01:07:39 PDT
Created attachment 108118 [details]
proposed patch
Comment 2 Eric Carlson 2011-09-21 07:37:09 PDT
(In reply to comment #0)
> 
> http://trac.webkit.org/changeset/95133 is the culprit, the fix is trivial though :)

Oh dear, that was me! I saw and fixed that, but it looks like I checked in the wrong version of that file :-(
Comment 3 Eric Carlson 2011-09-21 07:37:34 PDT
Comment on attachment 108118 [details]
proposed patch

Thanks!
Comment 4 Philippe Normand 2011-09-21 07:48:33 PDT
Committed r95628: <http://trac.webkit.org/changeset/95628>