Bug 68505 - [EFL] Fix alphabetical sorting problem
Summary: [EFL] Fix alphabetical sorting problem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 00:23 PDT by Gyuyoung Kim
Modified: 2011-09-21 07:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1019 bytes, patch)
2011-09-21 00:45 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (1.00 KB, patch)
2011-09-21 01:16 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-09-21 00:23:56 PDT
Fix wrong alphabetical sorting in ewk_util.cpp.
Comment 1 Gyuyoung Kim 2011-09-21 00:45:30 PDT
Created attachment 108114 [details]
Patch

Fix below problem.

Source/WebKit/efl/ewk/ewk_util.cpp:27:  Alphabetical sorting problem. [build/include_order] [4]
Comment 2 Zoltan Horvath 2011-09-21 01:13:59 PDT
Comment on attachment 108114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108114&action=review

> Source/WebKit/efl/ewk/ewk_util.cpp:28
>  #include "workers/WorkerThread.h"
>  
> -#include "ewk_private.h"
>  #include <eina_safety_checks.h>

You don't need this blank line.

Otherwise the change is okay, but I'm not a reviewer yet.
Comment 3 Gyuyoung Kim 2011-09-21 01:16:55 PDT
Created attachment 108119 [details]
Patch

Fixed.
Comment 4 WebKit Review Bot 2011-09-21 07:27:25 PDT
Comment on attachment 108119 [details]
Patch

Clearing flags on attachment: 108119

Committed r95627: <http://trac.webkit.org/changeset/95627>
Comment 5 WebKit Review Bot 2011-09-21 07:27:30 PDT
All reviewed patches have been landed.  Closing bug.