Bug 68492 - Clean up CSS Counter code
Summary: Clean up CSS Counter code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 17:44 PDT by Adam Klein
Modified: 2011-09-21 12:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.28 KB, patch)
2011-09-20 17:51 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Fix nitpick (13.38 KB, patch)
2011-09-21 11:22 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch for landing (13.38 KB, patch)
2011-09-21 11:24 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-09-20 17:44:45 PDT 
Clean up CSS Counter code
Comment 1 Adam Klein 2011-09-20 17:51:11 PDT 
Created attachment 108088 [details]
Patch
Comment 2 Adam Klein 2011-09-21 09:22:29 PDT 
Adding a couple reviewers who reviewed my previous change in this area (http://trac.webkit.org/changeset/95071).
Comment 3 Tony Chang 2011-09-21 10:22:46 PDT 
Comment on attachment 108088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108088&action=review

> Source/WebCore/css/CSSParser.cpp:3675
>          short ls = 0;

Nit: While we're here, this should probably be an int since CSSParserValue::id is an int and we should use a better variable name than ls (like cssValueID or listStyleID).
Comment 4 Adam Klein 2011-09-21 11:22:52 PDT 
Created attachment 108188 [details]
Fix nitpick
Comment 5 Adam Klein 2011-09-21 11:24:16 PDT 
Created attachment 108192 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-09-21 12:46:55 PDT 
Comment on attachment 108192 [details]
Patch for landing

Clearing flags on attachment: 108192

Committed r95664: <http://trac.webkit.org/changeset/95664>
Comment 7 WebKit Review Bot 2011-09-21 12:46:59 PDT 
All reviewed patches have been landed.  Closing bug.