Bug 68471 - Add webkit 'filter' value to RenderStyle
Summary: Add webkit 'filter' value to RenderStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks: 68469 68472
  Show dependency treegraph
 
Reported: 2011-09-20 14:05 PDT by Dean Jackson
Modified: 2011-09-27 12:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (44.63 KB, patch)
2011-09-26 15:40 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (45.41 KB, patch)
2011-09-26 17:30 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2011-09-20 14:05:43 PDT
filter needs to be exposed to all content
Comment 1 Radar WebKit Bug Importer 2011-09-20 14:08:14 PDT
<rdar://problem/10155630>
Comment 2 Dean Jackson 2011-09-21 13:31:49 PDT
This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:

1. prefixed version for HTML. SVG filter remains untouched.
2. implement prefixed version for SVG in addition to existing filter (who wins?)
3. eventually merge when we can drop prefix
Comment 3 Dirk Schulze 2011-09-22 00:55:24 PDT
(In reply to comment #2)
> This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:
> 
> 1. prefixed version for HTML. SVG filter remains untouched.
> 2. implement prefixed version for SVG in addition to existing filter (who wins?)

But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no?
Comment 4 Dean Jackson 2011-09-26 14:38:45 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:
> > 
> > 1. prefixed version for HTML. SVG filter remains untouched.
> > 2. implement prefixed version for SVG in addition to existing filter (who wins?)
> 
> But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no?

Yes, eventually. (And eventually is not that long away - I just don't want to disrupt the working SVG filter path while CSS is in flux)
Comment 5 Dean Jackson 2011-09-26 15:40:00 PDT
Created attachment 108738 [details]
Patch
Comment 6 Simon Fraser (smfr) 2011-09-26 15:46:41 PDT
Comment on attachment 108738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.h:230
> +    double m_offsetX;
> +    double m_offsetY;

What is this offset? Is it a blur radius? If so, how is it defined?
Comment 7 Dean Jackson 2011-09-26 15:47:59 PDT
(In reply to comment #6)
> (From update of attachment 108738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review
> 
> > Source/WebCore/platform/graphics/filters/FilterOperation.h:230
> > +    double m_offsetX;
> > +    double m_offsetY;
> 
> What is this offset? Is it a blur radius? If so, how is it defined?

Yes, a blur radius. We expose lengths into the filter operation. I expect we'll need to plumb them through similar to the way TranslateTransformOperation has to.
Comment 8 Dean Jackson 2011-09-26 17:30:26 PDT
Created attachment 108764 [details]
Patch
Comment 9 Dean Jackson 2011-09-26 17:33:56 PDT
New patch with Simon's change to stdDeviation. I guess I shouldn't copy the r+ (not even sure I can do that)
Comment 10 Dean Jackson 2011-09-27 12:48:56 PDT
http://trac.webkit.org/changeset/96142