Bug 68471 – Add webkit 'filter' value to RenderStyle

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

filter needs to be exposed to all content

[Radar WebKit Bug Importer]

<rdar://problem/10155630>

[Dean Jackson]

This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:

1. prefixed version for HTML. SVG filter remains untouched.
2. implement prefixed version for SVG in addition to existing filter (who wins?)
3. eventually merge when we can drop prefix

[Dirk Schulze]

(In reply to comment #2)
> This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:
> 
> 1. prefixed version for HTML. SVG filter remains untouched.
> 2. implement prefixed version for SVG in addition to existing filter (who wins?)

But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no?

[Dean Jackson]

(In reply to comment #3)
> (In reply to comment #2)
> > This is wrong. Obviously the property should be prefixed, so I'm retitling this to be implement a new RenderStyle value. I propose the implementation goes:
> > 
> > 1. prefixed version for HTML. SVG filter remains untouched.
> > 2. implement prefixed version for SVG in addition to existing filter (who wins?)
> 
> But you still plan to use the same work flow and the same CSS property for both, HTML and SVG, no?

Yes, eventually. (And eventually is not that long away - I just don't want to disrupt the working SVG filter path while CSS is in flux)

[Dean Jackson]

Created attachment 108738 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 108738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.h:230
> +    double m_offsetX;
> +    double m_offsetY;

What is this offset? Is it a blur radius? If so, how is it defined?

[Dean Jackson]

(In reply to comment #6)
> (From update of attachment 108738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108738&action=review
> 
> > Source/WebCore/platform/graphics/filters/FilterOperation.h:230
> > +    double m_offsetX;
> > +    double m_offsetY;
> 
> What is this offset? Is it a blur radius? If so, how is it defined?

Yes, a blur radius. We expose lengths into the filter operation. I expect we'll need to plumb them through similar to the way TranslateTransformOperation has to.

[Dean Jackson]

Created attachment 108764 [details]
Patch

[Dean Jackson]

New patch with Simon's change to stdDeviation. I guess I shouldn't copy the r+ (not even sure I can do that)

[Dean Jackson]

http://trac.webkit.org/changeset/96142