RESOLVED WONTFIX 68465
Do not consider SQLITE_BUSY an error in turnOnIncrementalAutoVacuum 
https://bugs.webkit.org/show_bug.cgi?id=68465
Summary Do not consider SQLITE_BUSY an error in turnOnIncrementalAutoVacuum
Raphael Kubo da Costa (:rakuco)
Reported 2011-09-20 13:34:02 PDT
Do not consider SQLITE_BUSY an error in turnOnIncrementalAutoVacuum
Attachments
Patch (2.04 KB, patch)
2011-09-20 13:38 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-09-20 13:38:56 PDT
Created attachment 108049 [details] Patch
Brent Fulgham
Comment 2 2011-11-10 10:09:38 PST
Comment on attachment 108049 [details] Patch Is it possible that this code was actually meant to be "if (error != SQLITE_BUSY)" rather than the original "if (error != SQLITE_ROW)"? I don't see anything in the SQLite documentation that mentions that SQLITE_ROW is an expected error result of PRAGMA auto_vacuum.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-11 16:01:52 PST
Perhaps SQLITE_ROW can come from some call invoked in SQLiteStatement::getColumnInt? I'm not sure either.
Michael Nordman
Comment 4 2012-04-19 19:09:31 PDT
In the context of WebSQLDatabase, this change looks harmless. Afaict the net effect is to avoid making a LOG_ERROR() call when the error is BUSY. I don't see any other callsites in the codebase to this method other than the one the AbstractDatabase class. But a return value of true in this case might be misleading, the auto_vacuum setting may or may not be set to the incremental mode. Another way to avoid the LOG_ERROR() output could be to test lastError() for the BUSY value after a false return at the callsite in AbstractDatabase. I'm not a reviewer here, so i can't help you out any further than that :)
Anders Carlsson
Comment 5 2014-02-05 10:50:47 PST
Comment on attachment 108049 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Anne van Kesteren
Comment 6 2024-03-06 00:22:25 PST
This is a feature that's disabled/removed.
Note You need to log in before you can comment on or make changes to this bug.