Bug 68456 – [Qt][WK2] Build dependency problems

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

https://bugs.webkit.org/show_bug.cgi?id=38054 fixed a general Qt 
specific build dependency problem if a define changes in features.pri. 

But it is a buggy little bit, because it doesn't respect WK2 build.
(This bug was revealed by http://trac.webkit.org/changeset/95551)

We should pass all config to compute_defaults call, like wk2 build.

[Kristóf Kosztyó]

Created attachment 110355 [details]
proposed fix

[Csaba Osztrogonác]

Comment on attachment 110355 [details]
proposed fix

r- now, because it doesn't solve the original problem.

ENABLE_FULLSCREEN_API=1 is still missing.

[Csaba Osztrogonác]

Comment on attachment 110355 [details]
proposed fix

I think CONFIG+="compute_defaults webkit2" would be better for wk2 build.
But the best solution would be if we pass everything to qmake to match
the real build session. For example: minimal build, defines, etc.

[Kristóf Kosztyó]

Created attachment 110506 [details]
proposed fix

[Csaba Osztrogonác]

Comment on attachment 110506 [details]
proposed fix

r=me

[WebKit Review Bot]

Comment on attachment 110506 [details]
proposed fix

Rejecting attachment 110506 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10080753

[Csaba Osztrogonác]

Comment on attachment 110506 [details]
proposed fix

Clearing flags on attachment: 110506

Committed r97622: <http://trac.webkit.org/changeset/97622>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.