Bug 68456 - [Qt][WK2] Build dependency problems
Summary: [Qt][WK2] Build dependency problems
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Kristóf Kosztyó
Keywords: Qt, QtTriaged
Depends on:
Reported: 2011-09-20 11:52 PDT by Csaba Osztrogonác
Modified: 2011-10-17 08:26 PDT (History)
4 users (show)

See Also:

proposed fix (1.13 KB, patch)
2011-10-10 07:01 PDT, Kristóf Kosztyó
ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
proposed fix (1.40 KB, patch)
2011-10-11 06:12 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-09-20 11:52:12 PDT
https://bugs.webkit.org/show_bug.cgi?id=38054 fixed a general Qt 
specific build dependency problem if a define changes in features.pri. 

But it is a buggy little bit, because it doesn't respect WK2 build.
(This bug was revealed by http://trac.webkit.org/changeset/95551)

We should pass all config to compute_defaults call, like wk2 build.
Comment 1 Kristóf Kosztyó 2011-10-10 07:01:20 PDT
Created attachment 110355 [details]
proposed fix
Comment 2 Csaba Osztrogonác 2011-10-10 07:09:42 PDT
Comment on attachment 110355 [details]
proposed fix

r- now, because it doesn't solve the original problem.

ENABLE_FULLSCREEN_API=1 is still missing.
Comment 3 Csaba Osztrogonác 2011-10-10 07:16:43 PDT
Comment on attachment 110355 [details]
proposed fix

I think CONFIG+="compute_defaults webkit2" would be better for wk2 build.
But the best solution would be if we pass everything to qmake to match
the real build session. For example: minimal build, defines, etc.
Comment 4 Kristóf Kosztyó 2011-10-11 06:12:31 PDT
Created attachment 110506 [details]
proposed fix
Comment 5 Csaba Osztrogonác 2011-10-17 03:55:29 PDT
Comment on attachment 110506 [details]
proposed fix

Comment 6 WebKit Review Bot 2011-10-17 03:58:01 PDT
Comment on attachment 110506 [details]
proposed fix

Rejecting attachment 110506 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10080753
Comment 7 Csaba Osztrogonác 2011-10-17 08:25:59 PDT
Comment on attachment 110506 [details]
proposed fix

Clearing flags on attachment: 110506

Committed r97622: <http://trac.webkit.org/changeset/97622>
Comment 8 Csaba Osztrogonác 2011-10-17 08:26:06 PDT
All reviewed patches have been landed.  Closing bug.