Bug 68449 - [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
Summary: [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 10:21 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-10-05 10:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2011-09-20 10:22 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-09-20 10:21:15 PDT 
[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-09-20 10:22:17 PDT 
Created attachment 108017 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-10-05 09:46:39 PDT 
CC'ing tonikitoo.
Comment 3 Antonio Gomes 2011-10-05 10:10:46 PDT 
Comment on attachment 108017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108017&action=review

> Tools/DumpRenderTree/efl/ImageDiff.cpp:220
> -static void printImageDifferences(const Evas_Object* baselineImage, Evas_Object* actualImage)
> +static void printImageDifferences(Evas_Object* baselineImage, Evas_Object* actualImage)

is this related?
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-10-05 10:26:23 PDT 
(In reply to comment #3)
> (From update of attachment 108017 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108017&action=review
> 
> > Tools/DumpRenderTree/efl/ImageDiff.cpp:220
> > -static void printImageDifferences(const Evas_Object* baselineImage, Evas_Object* actualImage)
> > +static void printImageDifferences(Evas_Object* baselineImage, Evas_Object* actualImage)
> 
> is this related?

Yes, otherwise we can't pass the non-const values to calculateDifference (which has also had its signature changed).
Comment 5 WebKit Review Bot 2011-10-05 10:50:31 PDT 
Comment on attachment 108017 [details]
Patch

Clearing flags on attachment: 108017

Committed r96723: <http://trac.webkit.org/changeset/96723>
Comment 6 WebKit Review Bot 2011-10-05 10:50:36 PDT 
All reviewed patches have been landed.  Closing bug.