Bug 68442 – [Qt] QTouchWebView missing signal tests for loadProgress

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gopal Raghavan]

Need signal tests for QTouchWebView loadProgress

[Gopal Raghavan]

Created attachment 108006 [details]
TouchWebView loadProgress signal test

Adding signal tests for TouchWebView.
This is very similar to DesktopWebView (68280).
Here is the test results:

********* Start testing of qmltests *********
Config: Using QTest library 5.0.0, Qt 5.0.0
PASS   : DesktopWebViewLoadProgress::initTestCase()
QWARN  : DesktopWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewLoadProgress::test_loadProgress()
PASS   : DesktopWebViewLoadProgress::cleanupTestCase()
PASS   : DesktopWebViewLoadProgressSignal::initTestCase()
QWARN  : DesktopWebViewLoadProgressSignal::test_loadProgressSignal() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewLoadProgressSignal::test_loadProgressSignal()
PASS   : DesktopWebViewLoadProgressSignal::cleanupTestCase()
QWARN  : qmltests::UnknownTestFunc() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewNavigationPolicyForUrl::initTestCase()
QWARN  : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread
PASS   : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy()
PASS   : DesktopWebViewNavigationPolicyForUrl::test_usePolicy()
PASS   : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase()
PASS   : DesktopWebViewProperties::initTestCase()
QWARN  : DesktopWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : DesktopWebViewProperties::test_title()
PASS   : DesktopWebViewProperties::test_url()
PASS   : DesktopWebViewProperties::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_load()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_loadNegativeSizeView() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_loadNegativeSizeView()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewLoadProgress::initTestCase()
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoadProgress::test_loadProgress()
PASS   : TouchWebViewLoadProgress::cleanupTestCase()
PASS   : TouchWebViewLoadProgressSignal::initTestCase()
QWARN  : TouchWebViewLoadProgressSignal::test_loadProgressSignal() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoadProgressSignal::test_loadProgressSignal()
PASS   : TouchWebViewLoadProgressSignal::cleanupTestCase()
PASS   : TouchWebViewLoad::initTestCase()
QWARN  : TouchWebViewLoad::test_loadZeroSizeView() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewLoad::test_loadZeroSizeView()
PASS   : TouchWebViewLoad::cleanupTestCase()
PASS   : TouchWebViewProperties::initTestCase()
QWARN  : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS   : TouchWebViewProperties::test_title()
PASS   : TouchWebViewProperties::test_url()
PASS   : TouchWebViewProperties::cleanupTestCase()
Totals: 33 passed, 0 failed, 0 skipped
********* Finished testing of qmltests *********

[Chang Shu]

I am not sure about the history of the QTouchWebView code. Why the tests were missing at the first place and why it's essential to add them now? Btw, do we run Qt tests on the buildbot?

[Gopal Raghavan]

Good question. I do not know why tests are missing. 
 
I am trying to rectify the situation by adding these api tests for coverage and regression. 

loadProgress Signal was not tested. So I think it is a good idea to add the test. We did similar thing for DesktopWebView. Reviewer also suggested to keep TouchWebView in sync.

[Chang Shu]

Comment on attachment 108006 [details]
TouchWebView loadProgress signal test

Sure. If the TouchWebView code has not been covered by any layout tests or other Qt api tests, it's good to add these qml tests. But we don't want to duplicate the coverage.

[WebKit Review Bot]

Comment on attachment 108006 [details]
TouchWebView loadProgress signal test

Clearing flags on attachment: 108006

Committed r95572: <http://trac.webkit.org/changeset/95572>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.