RESOLVED FIXED 68409
Refactor Heap allocation logic into separate AllocationSpace class 
https://bugs.webkit.org/show_bug.cgi?id=68409
Summary Refactor Heap allocation logic into separate AllocationSpace class
Oliver Hunt
Reported 2011-09-19 16:01:51 PDT
Refactor Heap allocation logic into separate AllocationSpace class
Attachments
Patch (40.33 KB, patch)
2011-09-19 16:05 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (39.90 KB, patch)
2011-09-20 10:24 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (40.96 KB, patch)
2011-09-20 10:32 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (41.04 KB, patch)
2011-09-20 11:28 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-09-19 16:05:25 PDT
Created attachment 107937 [details] Patch
Oliver Hunt
Comment 2 2011-09-19 16:14:31 PDT
Committed r95493: <http://trac.webkit.org/changeset/95493>
Ryosuke Niwa
Comment 3 2011-09-19 16:44:00 PDT
It seems like this patch broke JSC on Windows: 2> Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\JavaScriptCore.exp 2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "public: void * __thiscall JSC::Heap::allocate(struct JSC::MarkedSpace::SizeClass &)" (?allocate@Heap@JSC@@QAEPAXAAUSizeClass@MarkedSpace@2@@Z) 2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(struct JSC::MarkedSpace::SizeClass &)" (?allocateSlowCase@Heap@JSC@@AAEPAXAAUSizeClass@MarkedSpace@2@@Z) 2>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\JavaScriptCore.dll : fatal error LNK1120: 2 unresolved externals 2>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\JavaScriptCore\BuildLog.htm"
Ryosuke Niwa
Comment 4 2011-09-19 18:44:25 PDT
Thanks for http://trac.webkit.org/changeset/95496. But it's still failing to build for whatever reason :( http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21105/steps/compile-webkit/logs/stdio 2>JavaScriptCore.exp : error LNK2001: unresolved external symbol "public: void * __thiscall JSC::AllocationSpace::allocate(struct JSC::MarkedSpace::SizeClass &)" (?allocate@AllocationSpace@JSC@@QAEPAXAAUSizeCla It seems like cl.exe is getting confused by two overloaded allocate functions. I tried moving function definitions into the class definition but didn't help. Per IRC discussion with gbarra, I'm rolling out the patch for now.
Oliver Hunt
Comment 5 2011-09-20 10:24:56 PDT
Created attachment 108019 [details] Patch
Ryosuke Niwa
Comment 6 2011-09-20 10:28:25 PDT
Comment on attachment 108019 [details] Patch It seems like you'd have to modify JavaScriptCore.def as in http://trac.webkit.org/changeset/95496/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def ?
Oliver Hunt
Comment 7 2011-09-20 10:29:44 PDT
(In reply to comment #6) > (From update of attachment 108019 [details]) > It seems like you'd have to modify JavaScriptCore.def as in http://trac.webkit.org/changeset/95496/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def ? I'm waiting for the win ews to turn, then i'll remove the bogus export, then wait for it to turn again, and add the correct one.
Oliver Hunt
Comment 8 2011-09-20 10:32:10 PDT
Created attachment 108021 [details] Patch Remove the known bad exports
Oliver Hunt
Comment 9 2011-09-20 11:28:08 PDT
Created attachment 108031 [details] Patch Add missing export
Oliver Hunt
Comment 10 2011-09-20 11:31:55 PDT
Committed r95559: <http://trac.webkit.org/changeset/95559>
Note You need to log in before you can comment on or make changes to this bug.