Bug 68402 - WebViews are always inactive when used in NSPopover
Summary: WebViews are always inactive when used in NSPopover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P1 Major
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-19 15:32 PDT by Timothy Hatcher
Modified: 2011-09-20 06:37 PDT (History)
2 users (show)

See Also:

Attachments
Proposed Change (8.33 KB, patch)
2011-09-19 15:41 PDT, Timothy Hatcher 		sullivan: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-09-19 15:32:28 PDT 
A WebView that is used in an NSPopover gets no hover or mouse move events, nor do CSS hovers work. The blinking insertion point also does not draw and text selection is always the inactive color.

<rdar://problem/9754099>
Comment 1 Timothy Hatcher 2011-09-19 15:41:11 PDT 
Created attachment 107931 [details]
Proposed Change
Comment 2 John Sullivan 2011-09-19 15:48:26 PDT 
Comment on attachment 107931 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:3383
> +    // unless the parent window looses key. So we need to remove the mouse moved observer.

Typo, “looses” should be “loses”.
Comment 3 Darin Adler 2011-09-19 15:52:52 PDT 
Comment on attachment 107931 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review

> Source/WebKit/mac/ChangeLog:3
> +        Make WebViews in NSPopovers render as they would in active windows.

What about WKView? Do we have the same problem with WebKit2?
Comment 4 Timothy Hatcher 2011-09-20 06:35:56 PDT 
(In reply to comment #3)
> (From update of attachment 107931 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107931&action=review
> 
> > Source/WebKit/mac/ChangeLog:3
> > +        Make WebViews in NSPopovers render as they would in active windows.
> 
> What about WKView? Do we have the same problem with WebKit2?

Filed as bug 68435 since I don't have a testcase for WKView yet, I'll fix it in a seperate patch.
Comment 5 Timothy Hatcher 2011-09-20 06:37:22 PDT 
Fixed in r95534. http://trac.webkit.org/changeset/95534