Bug 6839 – shouldInsertNode delegate returning NO shouldn't necessarily cancel a drag and drop

• Status: RESOLVED
• Resolution: WONTFIX
• Component: HTML Editing

[Duncan Wilcox]

Editing delegate methods exist both to forbid some behaviours and to replace built-in behaviours with more application specific ones.

Specifically, when performing a drag and drop into an editable area, this delegate method will be called:

- (BOOL)webView:(WebView *)webView shouldInsertNode:(DOMNode *)node replacingDOMRange:(DOMRange *)range givenAction:(WebViewInsertAction)action

if the delegate returns NO, the drop won't be accepted and the system will animate the dropped object returning where it came from.

This is the correct behaviour if the delegate wants to forbid the drop, but if the delegate wants to replace it with a different one, in fact it does want the drop to be accepted, albeit providing its own custom implementation of the functionality.

The delegate method above should be extended to reflect this.

[Justin Garcia]

I think the way to go here is to add replaceDOMRangeWithNode:.  We currently only provide a replaceSelectionWithNode:, which makes it cumbersome to do what Duncan describes w/o changing the current selection.  This should be a straightforward fix.

[Ahmad Saleem]

I think it is referring to following - https://github.com/WebKit/WebKit/blob/689b0ba375c8ad009024dac56d3d7713c6f5b7c6/Source/WebCore/loader/EmptyClients.cpp#L265

^ Do we need to need to extend the functionality or another functionality is now available to provide similar "replacement" experience based on drag and drop?

[Ryosuke Niwa]

This is won't fix at this point. WebKitLegacy has been deprecated.