WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68379
Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379
Summary
Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
Anders Carlsson
Reported
2011-09-19 12:59:34 PDT
Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
Attachments
Patch
(12.67 KB, patch)
2011-09-19 12:59 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-09-19 12:59:53 PDT
Created
attachment 107904
[details]
Patch
Adam Roben (:aroben)
Comment 2
2011-09-19 13:05:07 PDT
Comment on
attachment 107904
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=107904&action=review
> Source/WebKit/mac/ChangeLog:6 > + Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm > +
https://bugs.webkit.org/show_bug.cgi?id=68379
> + > + Reviewed by NOBODY (OOPS!).
Needs more explanation!
> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1232 > + // FIXME (Viewless): I assume we want the equivalent of this optimization for viewless mode too.
Seems like we don't need this FIXME anymore.
Anders Carlsson
Comment 3
2011-09-19 13:06:43 PDT
Committed
r95459
: <
http://trac.webkit.org/changeset/95459
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug