RESOLVED FIXED 68377
Remove calls to -[WebView _usesDocumentViews] 
https://bugs.webkit.org/show_bug.cgi?id=68377
Summary Remove calls to -[WebView _usesDocumentViews]
Anders Carlsson
Reported 2011-09-19 12:35:45 PDT
Remove calls to -[WebView _usesDocumentViews]
Attachments
Patch (4.88 KB, patch)
2011-09-19 12:38 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-09-19 12:38:28 PDT
Created attachment 107902 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-09-19 12:42:38 PDT
Comment on attachment 107902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107902&action=review > Source/WebKit/mac/ChangeLog:8 > + Remove calls to -[WebView _usesDocumentViews] > + https://bugs.webkit.org/show_bug.cgi?id=68377 > + > + Reviewed by NOBODY (OOPS!). > + > + Assume that -[WebView _usesDocumentViews] always returns true. It would be good to explain why we're doing this. (I think the reason is that this experiment has been abandoned.) Can we remove _usesDocumentViews itself?
Anders Carlsson
Comment 3 2011-09-19 12:43:34 PDT
(In reply to comment #2) > (From update of attachment 107902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107902&action=review > > > Source/WebKit/mac/ChangeLog:8 > > + Remove calls to -[WebView _usesDocumentViews] > > + https://bugs.webkit.org/show_bug.cgi?id=68377 > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + Assume that -[WebView _usesDocumentViews] always returns true. > > It would be good to explain why we're doing this. (I think the reason is that this experiment has been abandoned.) True. I'll add that. > > Can we remove _usesDocumentViews itself? Yes. I decided to do it in smaller steps though.
Anders Carlsson
Comment 4 2011-09-19 12:45:38 PDT
Committed r95458: <http://trac.webkit.org/changeset/95458>
Note You need to log in before you can comment on or make changes to this bug.