Bug 68377 - Remove calls to -[WebView _usesDocumentViews]
Summary: Remove calls to -[WebView _usesDocumentViews]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 12:35 PDT by Anders Carlsson
Modified: 2011-09-19 12:45 PDT (History)
0 users

See Also:


Attachments
Patch (4.88 KB, patch)
2011-09-19 12:38 PDT, Anders Carlsson
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-09-19 12:35:45 PDT
Remove calls to -[WebView _usesDocumentViews]
Comment 1 Anders Carlsson 2011-09-19 12:38:28 PDT
Created attachment 107902 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-09-19 12:42:38 PDT
Comment on attachment 107902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107902&action=review

> Source/WebKit/mac/ChangeLog:8
> +        Remove calls to -[WebView _usesDocumentViews]
> +        https://bugs.webkit.org/show_bug.cgi?id=68377
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Assume that -[WebView _usesDocumentViews] always returns true.

It would be good to explain why we're doing this. (I think the reason is that this experiment has been abandoned.)

Can we remove _usesDocumentViews itself?
Comment 3 Anders Carlsson 2011-09-19 12:43:34 PDT
(In reply to comment #2)
> (From update of attachment 107902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107902&action=review
> 
> > Source/WebKit/mac/ChangeLog:8
> > +        Remove calls to -[WebView _usesDocumentViews]
> > +        https://bugs.webkit.org/show_bug.cgi?id=68377
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Assume that -[WebView _usesDocumentViews] always returns true.
> 
> It would be good to explain why we're doing this. (I think the reason is that this experiment has been abandoned.)

True. I'll add that.

> 
> Can we remove _usesDocumentViews itself?

Yes. I decided to do it in smaller steps though.
Comment 4 Anders Carlsson 2011-09-19 12:45:38 PDT
Committed r95458: <http://trac.webkit.org/changeset/95458>