Bug 68374 - Fix patch and bug numbering in the mocktool simulation code
Summary: Fix patch and bug numbering in the mocktool simulation code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 11:30 PDT by Tom Zakrajsek
Modified: 2011-09-20 08:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (78.88 KB, patch)
2011-09-19 12:14 PDT, Tom Zakrajsek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zakrajsek 2011-09-19 11:30:10 PDT
This is to get rid of a few FIXME items by using a normal sequence for patch IDs
and bug IDs in the mocktool simulation code.

Current Patches
---------------
197 ->  1
128 ->  2
103 ->  3
104 ->  4
105 ->  5
106 ->  6
107 ->  7

Current Bugs
---------------
42  ->  1
75  ->  2
76  ->  3
77  ->  4
78  ->  5
Comment 1 Tom Zakrajsek 2011-09-19 11:31:43 PDT
There are some other things to fix in that code, but I didn't want to mix this checking with one doing anything else, for the reviewer's sake.  One minor complication was that queues_unittest.py assumed that 2 was an invalid patch ID.  I changed that test to use 1995.

One question.  Would you prefer to see the patch and bug ids as distinct from
each other.  If so, I could easily give each a base.  For example, patches at 10000 and bugs at 50000
Comment 2 Adam Barth 2011-09-19 11:44:02 PDT
Yeah, that will help make sure we don't confuse them.
Comment 3 Tom Zakrajsek 2011-09-19 12:14:09 PDT
Created attachment 107901 [details]
Patch
Comment 4 WebKit Review Bot 2011-09-20 08:42:13 PDT
Comment on attachment 107901 [details]
Patch

Clearing flags on attachment: 107901

Committed r95543: <http://trac.webkit.org/changeset/95543>
Comment 5 WebKit Review Bot 2011-09-20 08:42:17 PDT
All reviewed patches have been landed.  Closing bug.