RESOLVED FIXED Bug 68373
Remove direct property slot pointers from the instruction stream 
https://bugs.webkit.org/show_bug.cgi?id=68373
Summary Remove direct property slot pointers from the instruction stream
Oliver Hunt
Reported 2011-09-19 11:05:44 PDT
Remove direct property slot pointers from the instruction stream
Attachments
Patch (5.14 KB, patch)
2011-09-19 11:07 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-09-19 11:07:35 PDT
Created attachment 107889 [details] Patch
Oliver Hunt
Comment 2 2011-09-19 11:29:30 PDT
Committed r95447: <http://trac.webkit.org/changeset/95447>
Adam Roben (:aroben)
Comment 3 2011-09-19 12:28:14 PDT
This broke Windows (at least): http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21076/steps/compile-webkit/logs/stdio
Adam Roben (:aroben)
Comment 4 2011-09-19 12:29:32 PDT
Actually I think it broke 32-bit Mac, too: JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function 'void JSC::JIT::compileGetDirectOffset(JSC::JSObject*, JSC::X86Registers::RegisterID, JSC::X86Registers::RegisterID, size_t)': JavaScriptCore/jit/JITPropertyAccess32_64.cpp:462: error: 'result' was not declared in this scope cc1plus: warnings being treated as errors JavaScriptCore/jit/JITPropertyAccess32_64.cpp: At global scope: JavaScriptCore/jit/JITPropertyAccess32_64.cpp:459: warning: unused parameter 'resultPayload'
Note You need to log in before you can comment on or make changes to this bug.