Bug 68363 - Web Inspector: document Debugger.paused, introduce types for ids in Debugger domain.
Summary: Web Inspector: document Debugger.paused, introduce types for ids in Debugger ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 08:16 PDT by Pavel Feldman
Modified: 2011-09-20 06:59 PDT (History)
11 users (show)

See Also:


Attachments
Patch (47.17 KB, patch)
2011-09-19 08:21 PDT, Pavel Feldman
tonyg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-09-19 08:16:16 PDT
Migrates from poorly documented "details" object to explicit parameters containing break type and data.
Comment 1 Pavel Feldman 2011-09-19 08:21:21 PDT
Created attachment 107857 [details]
Patch
Comment 2 Pavel Podivilov 2011-09-20 01:58:26 PDT
(In reply to comment #1)
> Created an attachment (id=107857) [details]
> Patch

Looks good!
Comment 3 Tony Gentilcore 2011-09-20 05:59:37 PDT
Comment on attachment 107857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107857&action=review

> Source/WebCore/inspector/Inspector.json:1597
> +                    { "name": "breakpointId", "$ref": "BreakpointId", "description": "Id of the created breakpoint for further reference." },

s/Id/ID/ in strings throughout?
Comment 4 Pavel Feldman 2011-09-20 06:59:50 PDT
Committed r95538: <http://trac.webkit.org/changeset/95538>