Bug 68358 - Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Summary: Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cary Clark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 07:22 PDT by Cary Clark
Modified: 2011-09-19 11:26 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2011-09-19 07:26 PDT, Cary Clark
no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2011-09-19 09:33 PDT, Cary Clark
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-09-19 07:22:36 PDT
Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Comment 1 Cary Clark 2011-09-19 07:26:02 PDT
Created attachment 107850 [details]
Patch
Comment 2 mitz 2011-09-19 08:18:54 PDT
Comment on attachment 107850 [details]
Patch

Duplicating this code seems bad. A better solution would be to share it. r- because if you do copy this code, then you must also add the 2011 Apple Inc. copyright to the file.
Comment 3 Cary Clark 2011-09-19 08:31:04 PDT
I'm happy to share the code, but I am unsure where the shared code should reside. Where would you recommend?

Alternatively, would you still object to committing the code if the copyright statement was added to FontSkia.cpp?
Comment 4 Cary Clark 2011-09-19 08:53:05 PDT
How about moving the function from FontMac.mm to FontComplexTextMac.cpp. Does that work for you?
Comment 5 mitz 2011-09-19 09:04:58 PDT
(In reply to comment #4)
> How about moving the function from FontMac.mm to FontComplexTextMac.cpp.

That’s a good option
Comment 6 Cary Clark 2011-09-19 09:33:58 PDT
Created attachment 107874 [details]
Patch
Comment 7 WebKit Review Bot 2011-09-19 11:26:42 PDT
Comment on attachment 107874 [details]
Patch

Clearing flags on attachment: 107874

Committed r95445: <http://trac.webkit.org/changeset/95445>
Comment 8 WebKit Review Bot 2011-09-19 11:26:46 PDT
All reviewed patches have been landed.  Closing bug.