Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Created attachment 107850 [details]
Comment on attachment 107850 [details]
Duplicating this code seems bad. A better solution would be to share it. r- because if you do copy this code, then you must also add the 2011 Apple Inc. copyright to the file.
I'm happy to share the code, but I am unsure where the shared code should reside. Where would you recommend?
Alternatively, would you still object to committing the code if the copyright statement was added to FontSkia.cpp?
How about moving the function from FontMac.mm to FontComplexTextMac.cpp. Does that work for you?
(In reply to comment #4)
> How about moving the function from FontMac.mm to FontComplexTextMac.cpp.
That’s a good option
Created attachment 107874 [details]
Comment on attachment 107874 [details]
Clearing flags on attachment: 107874
Committed r95445: <http://trac.webkit.org/changeset/95445>
All reviewed patches have been landed. Closing bug.