Bug 68357 - [Qt][WK2] Make loading errors API easier to use.
Summary: [Qt][WK2] Make loading errors API easier to use.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-09-19 06:53 PDT by Alexis Menard (darktears)
Modified: 2011-09-19 14:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.10 KB, patch)
2011-09-19 06:58 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (14.09 KB, patch)
2011-09-19 07:01 PDT, Alexis Menard (darktears)
vestbo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-09-19 06:53:23 PDT
[Qt][WK2] Make loading errors API more easier to use.
Comment 1 Ademar Reis 2011-09-19 06:57:46 PDT
s/more easier/easier/
Comment 2 Alexis Menard (darktears) 2011-09-19 06:58:49 PDT
Created attachment 107848 [details]
Patch
Comment 3 WebKit Review Bot 2011-09-19 07:00:24 PDT
Attachment 107848 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexis Menard (darktears) 2011-09-19 07:01:28 PDT
Created attachment 107849 [details]
Patch
Comment 5 WebKit Review Bot 2011-09-19 07:03:31 PDT
Attachment 107849 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexis Menard (darktears) 2011-09-19 08:42:24 PDT
(In reply to comment #5)
> Attachment 107849 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
> 
> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h:72:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "errorType" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:88:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Total errors found: 4 in 12 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Added a patch in https://bugs.webkit.org/show_bug.cgi?id=68359 which fixes those warnings.
Comment 7 WebKit Review Bot 2011-09-19 11:03:19 PDT
Comment on attachment 107849 [details]
Patch

Rejecting attachment 107849 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9739798
Comment 8 Alexis Menard (darktears) 2011-09-19 13:32:11 PDT
Comment on attachment 107849 [details]
Patch

Let's try the cq again.
Comment 9 WebKit Review Bot 2011-09-19 13:35:43 PDT
Comment on attachment 107849 [details]
Patch

Rejecting attachment 107849 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9737938
Comment 10 Alexis Menard (darktears) 2011-09-19 14:09:06 PDT
Committed r95472: <http://trac.webkit.org/changeset/95472>