Bug 68356 - [EFL] Don't try to free user-provided list
Summary: [EFL] Don't try to free user-provided list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks: 68231
  Show dependency treegraph
 
Reported: 2011-09-19 06:43 PDT by Lucas De Marchi
Modified: 2011-09-21 12:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2011-09-19 06:51 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2011-09-19 08:03 PDT, Lucas De Marchi
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2011-09-19 06:43:24 PDT
[EFL] Don't try to free user-provided list
Comment 1 Lucas De Marchi 2011-09-19 06:51:01 PDT
Created attachment 107847 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-09-19 07:21:27 PDT
Comment on attachment 107847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107847&action=review

Informal r+ from my side.

> Source/WebKit/efl/ChangeLog:10
> +        (or whatever function is required to destroy it). However it just not

Small nit if you're really freak: it just not didn't use -> not only did it use; but also -> but it also
Comment 3 Lucas De Marchi 2011-09-19 08:03:49 PDT
Created attachment 107854 [details]
Patch
Comment 4 Gyuyoung Kim 2011-09-19 17:21:33 PDT
LGTM,
Comment 5 Lucas De Marchi 2011-09-21 11:58:37 PDT
Committed r95656: <http://trac.webkit.org/changeset/95656>
Comment 6 Lucas De Marchi 2011-09-21 12:20:13 PDT
Comment on attachment 107854 [details]
Patch

Clearing "cq?" flag.