Bug 68351 - [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
Summary: [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 05:41 PDT by chandra shekar vallala
Modified: 2011-09-21 09:39 PDT (History)
3 users (show)

See Also:


Attachments
patch for bug (1.39 KB, patch)
2011-09-19 05:49 PDT, chandra shekar vallala
fishd: review-
Details | Formatted Diff | Diff
updated patch (1.56 KB, patch)
2011-09-21 02:21 PDT, chandra shekar vallala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chandra shekar vallala 2011-09-19 05:41:44 PDT
ClearFocusedNode should clear selection of editable div node. Otherwise div node will still process the keyboard events even though focus has removed for the node.

The current implementation works for only text-filed and textarea.
Comment 1 chandra shekar vallala 2011-09-19 05:49:51 PDT
Created attachment 107840 [details]
patch for bug
Comment 2 Darin Fisher (:fishd, Google) 2011-09-19 10:41:07 PDT
Comment on attachment 107840 [details]
patch for bug

View in context: https://bugs.webkit.org/attachment.cgi?id=107840&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1806
> +        || (oldFocusedNode->hasTagName(HTMLNames::divTag)

Any block element can be made content editable.  Checking only for a DIV tag seems a bit too restrictive.
Comment 3 chandra shekar vallala 2011-09-21 02:21:47 PDT
Created attachment 108126 [details]
updated patch

updated patch as per comment.
Comment 4 WebKit Review Bot 2011-09-21 09:38:56 PDT
Comment on attachment 108126 [details]
updated patch

Clearing flags on attachment: 108126

Committed r95640: <http://trac.webkit.org/changeset/95640>
Comment 5 WebKit Review Bot 2011-09-21 09:39:00 PDT
All reviewed patches have been landed.  Closing bug.