Bug 68346 - [GTK] Fix distcheck build
Summary: [GTK] Fix distcheck build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 03:21 PDT by Carlos Garcia Campos
Modified: 2011-09-19 23:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.96 KB, patch)
2011-09-19 03:24 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-09-19 03:21:23 PDT
make distcheck doesn't currently work.
Comment 1 Carlos Garcia Campos 2011-09-19 03:24:57 PDT
Created attachment 107826 [details]
Patch
Comment 2 Philippe Normand 2011-09-19 04:14:47 PDT
Comment on attachment 107826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review

Looks good overall, just a doubt of the mime-type handling test.

> Source/WebKit/gtk/tests/testmimehandling.c:-79
> -    } else if (g_str_equal(path, "/ogg")) {

Hum, why remove this part of the test? If it fails we'd better fix it.
Comment 3 Carlos Garcia Campos 2011-09-19 04:22:25 PDT
(In reply to comment #2)
> (From update of attachment 107826 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review
> 
> Looks good overall, just a doubt of the mime-type handling test.
> 
> > Source/WebKit/gtk/tests/testmimehandling.c:-79
> > -    } else if (g_str_equal(path, "/ogg")) {
> 
> Hum, why remove this part of the test? If it fails we'd better fix it.

Soup behaviour has changed, the "fix" would depend on soup version, so we should bump the soup requirements to make sure the test won't fail. See:

https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8

So, for now we have decided to remove that part of the test.
Comment 4 Philippe Normand 2011-09-19 04:34:27 PDT
Oh, OK then :) I've missed that link you also mentionned in the ChangeLog, sorry.
Comment 5 WebKit Review Bot 2011-09-19 09:21:07 PDT
Comment on attachment 107826 [details]
Patch

Clearing flags on attachment: 107826

Committed r95417: <http://trac.webkit.org/changeset/95417>
Comment 6 WebKit Review Bot 2011-09-19 09:21:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Martin Robinson 2011-09-19 10:09:01 PDT
In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder.
Comment 8 Carlos Garcia Campos 2011-09-19 23:39:23 PDT
(In reply to comment #7)
> In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder.

Ok, sorry, in this case just updating libsoup wound't work, we need to rethink the test itself, but still, you are right.