Bug 68343 - [chromium] Disable clang when building chromium in WebKit
Summary: [chromium] Disable clang when building chromium in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-19 02:11 PDT by jochen
Modified: 2011-09-19 12:18 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2011-09-19 02:13 PDT, jochen
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2011-09-19 10:54 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2011-09-19 02:11:37 PDT
[chromium] Disable clang when building chromium in WebKit
Comment 1 jochen 2011-09-19 02:13:18 PDT
Created attachment 107818 [details]
Patch
Comment 2 jochen 2011-09-19 02:17:39 PDT
an alternative would be to add a dependencies on tools/clang
Comment 3 Nico Weber 2011-09-19 06:40:48 PDT
Comment on attachment 107818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107818&action=review

LGTM, sorry for the breakage.

You can submit this as "Unreviewed, build fix" (then you don't need to wait for a formal r+).

> Source/WebKit/chromium/gyp_webkit:107
> +               '-Dclang_use_chrome_plugins=0',

This line should be enough, you shouldn't need the one above it (but it doesn't hurt either). Maybe add "# http://crbug.com/97043".
Comment 4 Adam Barth 2011-09-19 10:48:06 PDT
Adding a dependency on tools/clang seems better.  We want the upstream and downstream builds to use the same compiler.
Comment 5 Nico Weber 2011-09-19 10:49:20 PDT
(In reply to comment #4)
> Adding a dependency on tools/clang seems better.  We want the upstream and downstream builds to use the same compiler.

Yes, I'll get to that. But since the build uses gcc at the moment anyway, unbreaking this until I do seems better than leaving it broken.
Comment 6 jochen 2011-09-19 10:54:03 PDT
Created attachment 107885 [details]
Patch
Comment 7 Adam Barth 2011-09-19 11:02:26 PDT
Comment on attachment 107885 [details]
Patch

Okiedokes!
Comment 8 WebKit Review Bot 2011-09-19 12:18:54 PDT
Comment on attachment 107885 [details]
Patch

Clearing flags on attachment: 107885

Committed r95454: <http://trac.webkit.org/changeset/95454>
Comment 9 WebKit Review Bot 2011-09-19 12:18:58 PDT
All reviewed patches have been landed.  Closing bug.