This change fixes semantics of the MessageSource and MessageType: MessageSource is now the source of the message (be it Network, HTML parser or Console API) MessageType is only defined for the Console API messages and contains the name of the API call (log, dir, dirxml, etc.). Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType private to the inspector.
Created attachment 107825 [details] Patch
Comment on attachment 107825 [details] Patch Attachment 107825 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9744296
Created attachment 107858 [details] [Path] Mac bot fixed.
Comment on attachment 107858 [details] [Path] Mac bot fixed. View in context: https://bugs.webkit.org/attachment.cgi?id=107858&action=review > Source/WebCore/inspector/front-end/ConsoleMessage.js:98 > + case WebInspector.ConsoleMessage.MessageType.Dir: We should not switch between MessageTypes unless MessageSource is ConsoleAPI. Please put switch behind a conditional operator and make MessageType optional in protocol. Otherwise looks good.
Created attachment 107879 [details] [Patch] Review comments addressed
Created attachment 107884 [details] [Patch] rebaselined 2.
Created attachment 107886 [details] [Patch] rebaselined 3.
LGTM
Comment on attachment 107886 [details] [Patch] rebaselined 3. View in context: https://bugs.webkit.org/attachment.cgi?id=107886&action=review > Source/WebCore/inspector/Inspector.json:335 > + "description": "Console domain defines methods and events for interaction with the JavaScript console. Console collects messages created by means of the <a href='http://getfirebug.com/wiki/index.php/Console_API'>JavaScript Console API</a>. One needs to enable this domain using <code>enable</code> command in order to start receiving the console messages. Browser collects messages issued while console domain is not enabled as well and reports them using <code>messageAdded</code> notification upon enabling.", I take it these strings are localized so it is fine to change them in place?
Comment on attachment 107886 [details] [Patch] rebaselined 3. View in context: https://bugs.webkit.org/attachment.cgi?id=107886&action=review >> Source/WebCore/inspector/Inspector.json:335 >> + "description": "Console domain defines methods and events for interaction with the JavaScript console. Console collects messages created by means of the <a href='http://getfirebug.com/wiki/index.php/Console_API'>JavaScript Console API</a>. One needs to enable this domain using <code>enable</code> command in order to start receiving the console messages. Browser collects messages issued while console domain is not enabled as well and reports them using <code>messageAdded</code> notification upon enabling.", > > I take it these strings are localized so it is fine to change them in place? Protocol description is not localized.
Committed r95535: <http://trac.webkit.org/changeset/95535>