Bug 68336 - Implement an ErrorEvent constructor for V8
Summary: Implement an ErrorEvent constructor for V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency treegraph
 
Reported: 2011-09-18 23:59 PDT by Kentaro Hara
Modified: 2011-10-11 18:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.96 KB, patch)
2011-09-19 00:38 PDT, Kentaro Hara
abarth: review+
Details | Formatted Diff | Diff
rebased patch for commit (6.03 KB, patch)
2011-09-28 01:20 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-18 23:59:45 PDT
We have been working on implementing constructors of Events. ErrorEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=67924), but do not have it in V8.
Comment 1 Kentaro Hara 2011-09-19 00:38:22 PDT
Created attachment 107812 [details]
Patch
Comment 2 Kentaro Hara 2011-09-19 00:38:41 PDT
I confirmed that fast/events/constructors/error-event-constructor.html passes clang build.

The numerical conversion problem (https://bugs.webkit.org/show_bug.cgi?id=67980) seems to happen on an unsigned long long value but not to happen on an unsigned long value.
Comment 3 Kentaro Hara 2011-09-28 01:20:32 PDT
Created attachment 108984 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2011-09-28 02:27:04 PDT
Comment on attachment 108984 [details]
rebased patch for commit

Clearing flags on attachment: 108984

Committed r96208: <http://trac.webkit.org/changeset/96208>