Bug 68324 – [Gtk] metaKey modifier is not working with eventSender object

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Devdatta Deshpande]

The metaKey modifier is not working as expected with the eventSender object.
For e.g.
eventSender.mouseDown(["metaKey"])
eventSender.mouseUp(["metaKey"])
eventSender.keyDown(["metaKey"])

should set the event.metaKey to true in the corresponding JavaScript event callback. But event.metaKey always returns false when the event is sent using eventSender object.

[Devdatta Deshpande]

Created attachment 107789 [details]
Patch

[Xan Lopez]

Comment on attachment 107789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107789&action=review

Looks good overall, r- for a few small comments. Thanks for the patch!

> Tools/DumpRenderTree/gtk/EventSender.cpp:281
>      else if (JSStringIsEqualToUTF8CString(string, "metaKey"))

The indentation seems to be a bit screwed here?

> LayoutTests/ChangeLog:9
> +        using evnetSender object.

s/evnet/event/

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:13
> +            return;

This seems a bit unnecessary? I'd just have metakey =false; <events with no metakey>; metakey = true; <events with metakey>; and set failed to true if the invariant breaks at any point?

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:38
> +    resultDiv.innerHTML = (true == failed) ? "FAIL" : "PASS";

Simply failed?

[Martin Robinson]

Closing this since WebKit1 is gone.