Bug 68313 - Web Inspector: chromium: "Save timeline data" does nothing .
Summary: Web Inspector: chromium: "Save timeline data" does nothing .
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-17 12:15 PDT by Ilya Tikhonovsky
Modified: 2011-09-18 22:33 PDT (History)
11 users (show)

See Also:


Attachments
[patch] initial version (1.41 KB, patch)
2011-09-17 12:30 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] second iteration (2.78 KB, patch)
2011-09-18 01:46 PDT, Ilya Tikhonovsky
pfeldman: review+
pfeldman: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-09-17 12:15:01 PDT
windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.
Comment 1 Ilya Tikhonovsky 2011-09-17 12:30:51 PDT
Created attachment 107771 [details]
[patch] initial version
Comment 2 Ilya Tikhonovsky 2011-09-18 01:46:33 PDT
Created attachment 107788 [details]
[patch] second iteration
Comment 3 Pavel Feldman 2011-09-18 05:29:25 PDT
Comment on attachment 107788 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=107788&action=review

> Source/WebCore/inspector/front-end/utilities.js:552
> +           (!offset ? "Z" : offsetString);

No need to include 'Z' and offset. No Z should be treated as local (non UTC time).
Comment 4 Ilya Tikhonovsky 2011-09-18 22:33:47 PDT
Committed r95401: <http://trac.webkit.org/changeset/95401>