Bug 68293 - FrameLoaderClient BackForwardList-related methods are unused
: FrameLoaderClient BackForwardList-related methods are unused
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: History
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Mihai Parparita
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-16 17:11 PDT by Mihai Parparita
Modified: 2011-09-17 16:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (32.55 KB, patch)
2011-09-16 17:35 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-09-16 17:11:16 PDT
As far as I can tell, dispatchDidAddBackForwardItem, dispatchDidRemoveBackForwardItem and dispatchDidChangeBackForwardIndex all have no-op implementations in the various FrameLoaderClient implementations. It looks like they were added by http://trac.webkit.org/changeset/51629 for the old Android port. I assume they're no longer needed for the new (Chromium-based) one?
Comment 1 Adam Barth 2011-09-16 17:12:37 PDT
It's unlikely they'll be needed by the new Android port because it shares its back/forward logic with the other Chromium ports.
Comment 2 Mihai Parparita 2011-09-16 17:13:00 PDT
I'll remove them.
Comment 3 Mihai Parparita 2011-09-16 17:35:53 PDT
Created attachment 107753 [details]
Patch
Comment 4 Mihai Parparita 2011-09-16 17:39:30 PDT
Will wait for the EWS to go through this patch before trying to land it.
Comment 5 WebKit Review Bot 2011-09-17 16:31:00 PDT
Comment on attachment 107753 [details]
Patch

Clearing flags on attachment: 107753

Committed r95387: <http://trac.webkit.org/changeset/95387>
Comment 6 WebKit Review Bot 2011-09-17 16:31:05 PDT
All reviewed patches have been landed.  Closing bug.