Bug 68293 - FrameLoaderClient BackForwardList-related methods are unused
: FrameLoaderClient BackForwardList-related methods are unused
Status: RESOLVED FIXED
: WebKit
History
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-09-16 17:11 PST by
Modified: 2011-09-17 16:31 PST (History)


Attachments
Patch (32.55 KB, patch)
2011-09-16 17:35 PST, Mihai Parparita
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-09-16 17:11:16 PST
As far as I can tell, dispatchDidAddBackForwardItem, dispatchDidRemoveBackForwardItem and dispatchDidChangeBackForwardIndex all have no-op implementations in the various FrameLoaderClient implementations. It looks like they were added by http://trac.webkit.org/changeset/51629 for the old Android port. I assume they're no longer needed for the new (Chromium-based) one?
------- Comment #1 From 2011-09-16 17:12:37 PST -------
It's unlikely they'll be needed by the new Android port because it shares its back/forward logic with the other Chromium ports.
------- Comment #2 From 2011-09-16 17:13:00 PST -------
I'll remove them.
------- Comment #3 From 2011-09-16 17:35:53 PST -------
Created an attachment (id=107753) [details]
Patch
------- Comment #4 From 2011-09-16 17:39:30 PST -------
Will wait for the EWS to go through this patch before trying to land it.
------- Comment #5 From 2011-09-17 16:31:00 PST -------
(From update of attachment 107753 [details])
Clearing flags on attachment: 107753

Committed r95387: <http://trac.webkit.org/changeset/95387>
------- Comment #6 From 2011-09-17 16:31:05 PST -------
All reviewed patches have been landed.  Closing bug.