Bug 68291 – ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Tony Chang]

When loading a multipart page, I hit this assert in Chrome.  It seems to work fine when using test_shell.

ASSERTION FAILED: documentLoader
../../third_party/WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597) : static void WebCore::InspectorInstrumentation::loadEventFiredImpl(WebCore::InstrumentingAgents*, WebCore::Frame*, const WebCore::KURL&)


Specifically, if I run "out/Debug/chrome http://localhost:8099/multipart", I hit the assert.

I've attached the python webserver (just run python test-server-simple.py to launch).

[Tony Chang]

Created attachment 107745 [details]
test server

[Vsevolod Vlasov]

Probably related: http://code.google.com/p/chromium/issues/detail?id=94392

[Vsevolod Vlasov]

Created attachment 108323 [details]
Patch

[Vsevolod Vlasov]

I was not able to reproduce this bug, but this piece of code could be simplified to ensure this does not happens anymore.

[WebKit Review Bot]

Comment on attachment 108323 [details]
Patch

Attachment 108323 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9794302

[Vsevolod Vlasov]

Created attachment 108368 [details]
Patch

[Tony Chang]

Comment on attachment 108368 [details]
Patch

Seems fine.  Might want to have someone more familiar with Inspector code also take a look.

[Yury Semikhatsky]

(In reply to comment #7)
> (From update of attachment 108368 [details])
> Seems fine.  Might want to have someone more familiar with Inspector code also take a look.

Tony, are you sure url != documentLoader->requestURL() check was redundant there?

[Yury Semikhatsky]

Comment on attachment 108368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108368&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:-602
> -    if (frame->page()->mainFrame() != frame || url != documentLoader->requestURL())

Do we receive load event notifications only for the frame main resource? If not, the check should be preserved.

[Vsevolod Vlasov]

(In reply to comment #9)
> (From update of attachment 108368 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108368&action=review
> 
> > Source/WebCore/inspector/InspectorInstrumentation.cpp:-602
> > -    if (frame->page()->mainFrame() != frame || url != documentLoader->requestURL())
> 
> Do we receive load event notifications only for the frame main resource? If not, the check should be preserved.

loadEventFired() and domContentLoadedEventFired() are called only from DOMWindow and Document always passing frame main resource url.

[Vsevolod Vlasov]

Committed r95790: <http://trac.webkit.org/changeset/95790>