RESOLVED FIXED 68276
3D transforms are flattened in WebKit2 snapshots 
https://bugs.webkit.org/show_bug.cgi?id=68276
Summary 3D transforms are flattened in WebKit2 snapshots
Simon Fraser (smfr)
Reported 2011-09-16 13:24:54 PDT
Images of WK2 views flatten 3d transforms (they do a flattening paint, rather than capturing the window). This breaks pixel tests that contain 3d rendering (e.g. compositing/flat-with-transformed-child.html), and means that Safari snapshots don't show 3d.
Attachments
Patch (20.25 KB, patch)
2011-10-06 14:15 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
TestInvocationCG diff (3.13 KB, patch)
2011-10-06 17:23 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch which fixes Windows build (7.98 KB, patch)
2011-10-10 16:26 PDT, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-10-12 12:21 PDT, Simon Fraser (smfr) 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-10-06 14:15:33 PDT
Created attachment 110018 [details] Patch
Darin Adler
Comment 2 2011-10-06 16:34:44 PDT
Comment on attachment 110018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110018&action=review > Tools/WebKitTestRunner/cg/TestInvocationCG.mm:47 > +namespace WTR { I think that if we used "svn move" I could see the changes to this file. Because we just added a new file, I can’t see the diffs.
Simon Fraser (smfr)
Comment 3 2011-10-06 16:47:39 PDT
git will end up detecting the rename and will show this as an svn mv on commit.
Simon Fraser (smfr)
Comment 4 2011-10-06 17:23:34 PDT
Created attachment 110064 [details] TestInvocationCG diff
Simon Fraser (smfr)
Comment 5 2011-10-10 14:01:57 PDT
http://trac.webkit.org/changeset/97082
Simon Fraser (smfr)
Comment 6 2011-10-10 14:23:57 PDT
Reopening: broke windows.
Simon Fraser (smfr)
Comment 7 2011-10-10 16:26:15 PDT
Created attachment 110431 [details] Patch which fixes Windows build
Simon Fraser (smfr)
Comment 8 2011-10-10 16:33:25 PDT
http://trac.webkit.org/changeset/97104
Adam Roben (:aroben)
Comment 9 2011-10-12 11:42:45 PDT
Comment on attachment 110431 [details] Patch which fixes Windows build View in context: https://bugs.webkit.org/attachment.cgi?id=110431&action=review > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:135 > + return WKImageCreateFromCGImage(windowSnapshotImage.get(), 0); This causes a leak. You need to adopt the image.
Simon Fraser (smfr)
Comment 10 2011-10-12 12:21:20 PDT
Created attachment 110719 [details] Patch
Simon Fraser (smfr)
Comment 11 2011-10-12 12:24:04 PDT
Comment on attachment 110719 [details] Patch http://trac.webkit.org/changeset/97285
Note You need to log in before you can comment on or make changes to this bug.