Bug 68276 - 3D transforms are flattened in WebKit2 snapshots
Summary: 3D transforms are flattened in WebKit2 snapshots
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on: 69784 69785
  Show dependency treegraph
Reported: 2011-09-16 13:24 PDT by Simon Fraser (smfr)
Modified: 2011-10-12 12:24 PDT (History)
5 users (show)

See Also:

Patch (20.25 KB, patch)
2011-10-06 14:15 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
TestInvocationCG diff (3.13 KB, patch)
2011-10-06 17:23 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch which fixes Windows build (7.98 KB, patch)
2011-10-10 16:26 PDT, Simon Fraser (smfr)
andersca: review+
Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-10-12 12:21 PDT, Simon Fraser (smfr)
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-09-16 13:24:54 PDT
Images of WK2 views flatten 3d transforms (they do a flattening paint, rather than capturing the window). This breaks pixel tests that contain 3d rendering (e.g. compositing/flat-with-transformed-child.html), and means that Safari snapshots don't show 3d.
Comment 1 Simon Fraser (smfr) 2011-10-06 14:15:33 PDT
Created attachment 110018 [details]
Comment 2 Darin Adler 2011-10-06 16:34:44 PDT
Comment on attachment 110018 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=110018&action=review

> Tools/WebKitTestRunner/cg/TestInvocationCG.mm:47
> +namespace WTR {

I think that if we used "svn move" I could see the changes to this file. Because we just added a new file, I can’t see the diffs.
Comment 3 Simon Fraser (smfr) 2011-10-06 16:47:39 PDT
git will end up detecting the rename and will show this as an svn mv on commit.
Comment 4 Simon Fraser (smfr) 2011-10-06 17:23:34 PDT
Created attachment 110064 [details]
TestInvocationCG diff
Comment 5 Simon Fraser (smfr) 2011-10-10 14:01:57 PDT
Comment 6 Simon Fraser (smfr) 2011-10-10 14:23:57 PDT
Reopening: broke windows.
Comment 7 Simon Fraser (smfr) 2011-10-10 16:26:15 PDT
Created attachment 110431 [details]
Patch which fixes Windows build
Comment 8 Simon Fraser (smfr) 2011-10-10 16:33:25 PDT
Comment 9 Adam Roben (:aroben) 2011-10-12 11:42:45 PDT
Comment on attachment 110431 [details]
Patch which fixes Windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=110431&action=review

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:135
> +    return WKImageCreateFromCGImage(windowSnapshotImage.get(), 0);

This causes a leak. You need to adopt the image.
Comment 10 Simon Fraser (smfr) 2011-10-12 12:21:20 PDT
Created attachment 110719 [details]
Comment 11 Simon Fraser (smfr) 2011-10-12 12:24:04 PDT
Comment on attachment 110719 [details]