Bug 68272 - [chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
Summary: [chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 13:01 PDT by Adrienne Walker
Modified: 2011-09-16 17:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (19.08 KB, patch)
2011-09-16 13:07 PDT, Adrienne Walker
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-09-16 13:01:13 PDT
[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
Comment 1 Adrienne Walker 2011-09-16 13:07:18 PDT
Created attachment 107712 [details]
Patch
Comment 2 James Robinson 2011-09-16 13:22:35 PDT
Comment on attachment 107712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107712&action=review

R=me but if you are going to make it a member function I think you should use LRC::m_context instead of passing one in.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:38
> +#include "cc/CCLayerTreeHost.h"

was this transitively pulled in earlier or something? I guess this is needed so ~LayerRendererChromium can see ~CCLayerTreeHost because of the RefPtr<>

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:154
> +    void drawTexturedQuad(GraphicsContext3D*, const TransformationMatrix& projectionMatrix, const TransformationMatrix& layerMatrix,

If this is gonna be a member function, why does it need a context to be passed in? LRCs have contexts
Comment 3 Adrienne Walker 2011-09-16 13:27:05 PDT
(In reply to comment #2)
> (From update of attachment 107712 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107712&action=review
> 
> R=me but if you are going to make it a member function I think you should use LRC::m_context instead of passing one in.

Oh, excellent point.  I'll clean up the context to use the member variable.  I made it a member function in the first place because it abstracts the use of GL a little bit more.
Comment 4 James Robinson 2011-09-16 13:30:38 PDT
Sure, ideally we'd hide the context completely inside of LRC - especially if at some point we want to start playing with different renderer implementations underneath the LayerTreeHostImpl.  That's all speculative for now, however.
Comment 5 Adrienne Walker 2011-09-16 17:32:20 PDT
Committed r95341: <http://trac.webkit.org/changeset/95341>