Bug 68272 – [chromium] Move quad drawing code from LayerChromium to LayerRendererChromium

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium

[Adrienne Walker]

Created attachment 107712 [details]
Patch

[James Robinson]

Comment on attachment 107712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107712&action=review

R=me but if you are going to make it a member function I think you should use LRC::m_context instead of passing one in.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:38
> +#include "cc/CCLayerTreeHost.h"

was this transitively pulled in earlier or something? I guess this is needed so ~LayerRendererChromium can see ~CCLayerTreeHost because of the RefPtr<>

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:154
> +    void drawTexturedQuad(GraphicsContext3D*, const TransformationMatrix& projectionMatrix, const TransformationMatrix& layerMatrix,

If this is gonna be a member function, why does it need a context to be passed in? LRCs have contexts

[Adrienne Walker]

(In reply to comment #2)
> (From update of attachment 107712 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107712&action=review
> 
> R=me but if you are going to make it a member function I think you should use LRC::m_context instead of passing one in.

Oh, excellent point.  I'll clean up the context to use the member variable.  I made it a member function in the first place because it abstracts the use of GL a little bit more.

[James Robinson]

Sure, ideally we'd hide the context completely inside of LRC - especially if at some point we want to start playing with different renderer implementations underneath the LayerTreeHostImpl.  That's all speculative for now, however.

[Adrienne Walker]

Committed r95341: <http://trac.webkit.org/changeset/95341>