Bug 68269 - Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
Summary: Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an AB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 12:49 PDT by Anders Carlsson
Modified: 2011-09-16 19:08 PDT (History)
1 user (show)

See Also:


Attachments
Patch (11.04 KB, patch)
2011-09-16 12:53 PDT, Anders Carlsson
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-09-16 12:49:08 PDT
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
Comment 1 Anders Carlsson 2011-09-16 12:53:49 PDT
Created attachment 107707 [details]
Patch
Comment 2 Geoffrey Garen 2011-09-16 13:03:31 PDT
Comment on attachment 107707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107707&action=review

r=me

> Source/WebKit2/UIProcess/WebUIClient.cpp:166
> +    if (!m_client.version) {

This is a particularly glaring case where our style rule that compares to 0 should use ! is bizarre and unreadable. Oh well.
Comment 3 Anders Carlsson 2011-09-16 13:11:04 PDT
Committed r95315: <http://trac.webkit.org/changeset/95315>