WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 68269
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269
Summary
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an AB...
Anders Carlsson
Reported
2011-09-16 12:49:08 PDT
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
Attachments
Patch
(11.04 KB, patch)
2011-09-16 12:53 PDT
,
Anders Carlsson
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-09-16 12:53:49 PDT
Created
attachment 107707
[details]
Patch
Geoffrey Garen
Comment 2
2011-09-16 13:03:31 PDT
Comment on
attachment 107707
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=107707&action=review
r=me
> Source/WebKit2/UIProcess/WebUIClient.cpp:166 > + if (!m_client.version) {
This is a particularly glaring case where our style rule that compares to 0 should use ! is bizarre and unreadable. Oh well.
Anders Carlsson
Comment 3
2011-09-16 13:11:04 PDT
Committed
r95315
: <
http://trac.webkit.org/changeset/95315
>
Ryosuke Niwa
Comment 4
2011-09-16 19:08:20 PDT
It seems like this patch broke WK2 tests:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/14919
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/14919/steps/layout-test/logs/stdio
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug