Bug 68268 - Give local builds of WebProcess different icon to distinguish them from built-in Safari’s WebProcess
Summary: Give local builds of WebProcess different icon to distinguish them from built...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 12:22 PDT by Alexey Proskuryakov
Modified: 2011-09-16 13:05 PDT (History)
0 users

See Also:

Attachments
proposed patch (134.45 KB, patch)
2011-09-16 12:32 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
updated patch (130.54 KB, patch)
2011-09-16 12:41 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-09-16 12:22:55 PDT 
It's difficult to pick a proper WebProcess to attach in Xcode - you don't want to attach to a production one when released Safari/WebKit is running.

Having a different icon in Xcode menu would help.
Comment 1 Alexey Proskuryakov 2011-09-16 12:32:31 PDT 
Created attachment 107704 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2011-09-16 12:41:24 PDT 
Created attachment 107706 [details]
updated patch

Re-did xcodeproj changes to remove traces of experimentation.
Comment 3 Darin Adler 2011-09-16 12:44:54 PDT 
Comment on attachment 107706 [details]
updated patch

Nothing here says why we want to do this. That’s why I can’t review.
Comment 4 Darin Adler 2011-09-16 12:57:18 PDT 
Comment on attachment 107706 [details]
updated patch

I see now; I missed the rationale that was in the bug. I think the real title of this bug should be:

    Give local builds of WebProcess different icon to distinguish then from built-in Safari’s WebProcess
Comment 5 Alexey Proskuryakov 2011-09-16 13:05:43 PDT 
Good point, renamed.

Committed <http://trac.webkit.org/changeset/95314>.