RESOLVED FIXED68265
add non-CG Webkit-Mac builds to flakiness dashboard 
https://bugs.webkit.org/show_bug.cgi?id=68265
Summary add non-CG Webkit-Mac builds to flakiness dashboard
epoger
Reported 2011-09-16 11:56:43 PDT
add non-CG Webkit-Mac builds to http://test-results.appspot.com/dashboards/flakiness_dashboard.html patterned after part of http://trac.webkit.org/changeset/93242
Attachments
Patch (4.17 KB, patch)
2011-09-16 12:00 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2011-09-16 12:15 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-09-16 12:00:24 PDT
Created attachment 107696 [details] Patch
Adam Barth
Comment 2 2011-09-16 12:04:33 PDT
Comment on attachment 107696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107696&action=review > Tools/ChangeLog:6 > + Reviewed by Adam Barth. Generally you should leave this line with the default text. The tools will fill it in properly based on whoever actually reviews the patch. > Tools/ChangeLog:7 > + It's also a good idea to fill out some of the ChangeLog entry with an explanation of why you're making this change. In this case, I'd say something about how we're preparing to make these the default builders. > Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:36 > -// FIXME: move this over to using qunit > +// FIXME(ojan): move this over to using qunit WebKit doesn't use the (ojan) notation. Just FIXME.
epoger
Comment 3 2011-09-16 12:15:04 PDT
Created attachment 107698 [details] Patch
epoger
Comment 4 2011-09-16 12:17:55 PDT
fixed the issues Adam pointed out.
Adam Barth
Comment 5 2011-09-16 12:46:47 PDT
Comment on attachment 107698 [details] Patch Thanks!
WebKit Review Bot
Comment 6 2011-09-16 22:52:56 PDT
Comment on attachment 107698 [details] Patch Clearing flags on attachment: 107698 Committed r95370: <http://trac.webkit.org/changeset/95370>
WebKit Review Bot
Comment 7 2011-09-16 22:53:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.