Bug 68265 - add non-CG Webkit-Mac builds to flakiness dashboard
Summary: add non-CG Webkit-Mac builds to flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 11:56 PDT by epoger
Modified: 2011-09-16 22:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2011-09-16 12:00 PDT, epoger 		no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2011-09-16 12:15 PDT, epoger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-09-16 11:56:43 PDT 
add non-CG Webkit-Mac builds to http://test-results.appspot.com/dashboards/flakiness_dashboard.html

patterned after part of http://trac.webkit.org/changeset/93242
Comment 1 epoger 2011-09-16 12:00:24 PDT 
Created attachment 107696 [details]
Patch
Comment 2 Adam Barth 2011-09-16 12:04:33 PDT 
Comment on attachment 107696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107696&action=review

> Tools/ChangeLog:6
> +        Reviewed by Adam Barth. 

Generally you should leave this line with the default text.  The tools will fill it in properly based on whoever actually reviews the patch.

> Tools/ChangeLog:7
> +

It's also a good idea to fill out some of the ChangeLog entry with an explanation of why you're making this change.  In this case, I'd say something about how we're preparing to make these the default builders.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:36
> -// FIXME: move this over to using qunit
> +// FIXME(ojan): move this over to using qunit

WebKit doesn't use the (ojan) notation.  Just FIXME.
Comment 3 epoger 2011-09-16 12:15:04 PDT 
Created attachment 107698 [details]
Patch
Comment 4 epoger 2011-09-16 12:17:55 PDT 
fixed the issues Adam pointed out.
Comment 5 Adam Barth 2011-09-16 12:46:47 PDT 
Comment on attachment 107698 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2011-09-16 22:52:56 PDT 
Comment on attachment 107698 [details]
Patch

Clearing flags on attachment: 107698

Committed r95370: <http://trac.webkit.org/changeset/95370>
Comment 7 WebKit Review Bot 2011-09-16 22:53:01 PDT 
All reviewed patches have been landed.  Closing bug.