Bug 68252 - update-webkit-chromium should retry the gclient call if it fails once
Summary: update-webkit-chromium should retry the gclient call if it fails once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 10:02 PDT by Tom Zakrajsek
Modified: 2011-09-16 21:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2011-09-16 10:09 PDT, Tom Zakrajsek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zakrajsek 2011-09-16 10:02:43 PDT 
update-webkit-chromium sometimes fails when run from the bots because gclient can be flaky, as demonstrated in https://bugs.webkit.org/show_bug.cgi?id=67857#c6.  We should allow the script to retry the gclient call in case a given failure is transient.
Comment 1 Tom Zakrajsek 2011-09-16 10:09:04 PDT 
Created attachment 107674 [details]
Patch
Comment 2 Adam Barth 2011-09-16 10:12:15 PDT 
Comment on attachment 107674 [details]
Patch

Do we want to back-off at all?  There are also cases where gclient fails because you've screwed up editing the GYP file, and those shouldn't be retried...  This is probably a good start though.
Comment 3 Tom Zakrajsek 2011-09-16 10:21:33 PDT 
I'm not sure how to determine which failures should or shouldn't be retried.  Maybe based on the specific errorcode?  I'll think about ways to identify which ones would make sense to retry or not.

I think the worst current case would be that if you break a gyp file, it will retry (with no chance of success) and cost a little extra time.
Comment 4 WebKit Review Bot 2011-09-16 21:14:18 PDT 
Comment on attachment 107674 [details]
Patch

Clearing flags on attachment: 107674

Committed r95363: <http://trac.webkit.org/changeset/95363>
Comment 5 WebKit Review Bot 2011-09-16 21:14:23 PDT 
All reviewed patches have been landed.  Closing bug.