Bug 68240 - Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
Summary: Web Inspector: paint box model colors in Metrics sidebar at all times, do not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 05:27 PDT by Pavel Feldman
Modified: 2011-09-21 06:34 PDT (History)
10 users (show)

See Also:


Attachments
Patch (18.26 KB, patch)
2011-09-16 05:47 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] for landing (21.95 KB, patch)
2011-09-21 06:31 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-09-16 05:27:01 PDT
1. Today we paint backgrounds in Metrics box model on hover only - should be painted at all times for the reference.
2. Outlining boxes is highlight is wrong since outlines are outside the corresponding box regions. We've seen few reports on that + Firebug does not do borders for that reason.
Comment 1 Pavel Feldman 2011-09-16 05:47:04 PDT
Created attachment 107640 [details]
Patch
Comment 2 Yury Semikhatsky 2011-09-21 05:21:51 PDT
Comment on attachment 107640 [details]
Patch

Looks good, but it was more interactive when rectangle under cursor was highlighted in the metrics box on mouse hover. Would be nice to preserve that behavior.
Comment 3 Pavel Feldman 2011-09-21 06:31:35 PDT
Created attachment 108142 [details]
[Patch] for landing
Comment 4 Pavel Feldman 2011-09-21 06:32:18 PDT
Committed r95621: <http://trac.webkit.org/changeset/95621>