Bug 68239 - Depend on harfbuzz for OS=Android as well
Summary: Depend on harfbuzz for OS=Android as well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 66689
  Show dependency treegraph
 
Reported: 2011-09-16 04:30 PDT by Peter Beverloo
Modified: 2011-09-16 19:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2011-09-16 04:33 PDT, Peter Beverloo
steveblock: review+
Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2011-09-16 04:50 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2011-09-16 04:30:41 PDT
Android depends on harfbuzz as well, so reflect that in the project file.  Furthermore, fix a compile error in PopupListBox.cpp by explicitly including ctype.h, as isspace otherwise won't be enabled.
Comment 1 Peter Beverloo 2011-09-16 04:33:14 PDT
Created attachment 107634 [details]
Patch
Comment 2 Steve Block 2011-09-16 04:46:17 PDT
Comment on attachment 107634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review

> Source/WebCore/ChangeLog:6
> +        Android depends on harfbuzz as well, so reflect that in the project

'as well as GTK'

> Source/WebCore/ChangeLog:8
> +        explicitly including ctype.h, as isspace otherwise won't be enabled.

s/enabled/declared ?
Comment 3 Peter Beverloo 2011-09-16 04:50:27 PDT
Created attachment 107637 [details]
Patch

(In reply to comment #2)
> (From update of attachment 107634 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +        Android depends on harfbuzz as well, so reflect that in the project
> 
> 'as well as GTK'

That would say that Android depends on GTK too, which is not the case.  I've rephrased the sentence.

> 
> > Source/WebCore/ChangeLog:8
> > +        explicitly including ctype.h, as isspace otherwise won't be enabled.
> 
> s/enabled/declared ?

Done.

Thanks!
Comment 4 Steve Block 2011-09-16 04:53:45 PDT
Comment on attachment 107637 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2011-09-16 19:41:21 PDT
Comment on attachment 107637 [details]
Patch

Clearing flags on attachment: 107637

Committed r95356: <http://trac.webkit.org/changeset/95356>
Comment 6 WebKit Review Bot 2011-09-16 19:41:25 PDT
All reviewed patches have been landed.  Closing bug.