WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68234
Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234
Summary
Web Inspector: UI performance tests are required.
Ilya Tikhonovsky
Reported
2011-09-16 01:29:21 PDT
The idea is to create a set of tests which cover the frequently used UI actions and print the average time of these actions.
Attachments
[patch] initial version
(18.49 KB, patch)
2011-09-16 01:37 PDT
,
Ilya Tikhonovsky
pfeldman
: review-
Details
Formatted Diff
Diff
[patch] initial version
(6.36 KB, patch)
2011-09-16 05:51 PDT
,
Ilya Tikhonovsky
pfeldman
: review-
Details
Formatted Diff
Diff
[patch] third version
(6.62 KB, patch)
2011-09-16 07:10 PDT
,
Ilya Tikhonovsky
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-09-16 01:37:47 PDT
Created
attachment 107624
[details]
[patch] initial version
Pavel Feldman
Comment 2
2011-09-16 02:17:09 PDT
Comment on
attachment 107624
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=107624&action=review
> LayoutTests/inspector/performance/show-panel-network.html:19 > + RuntimeAgent.evaluate("makeXHRRequests(30)");
You should do InspectorTest.evaluateInPage("...", callback)
> LayoutTests/inspector/performance/show-panel-network.html:21 > + var Test = function() {
I don't think declarative notation will be flexible enough for this kind of tests. I'd suggest to stick with imperative form: InspectorTest.runPerformanceTest({ setUp: function(done) { WebInspector.showPanel("audits"); done(); }, run: function(done) { WebInspector.showPanel("network"); WebInspector.panels.network.refresh(); done(); } }, "show-network-panel", 1000); Or InspectorTest.runPerformanceTest({ run: function(timer, done) { WebInspector.showPanel("audits"); var timer = startTimer("show-network-panel"); WebInspector.showPanel("network"); WebInspector.panels.network.refresh(); timer.endTimer(); done(); } }, 1000);
> LayoutTests/inspector/performance/show-panel-network.html:23 > + this.object = WebInspector;
This is too generic.
> LayoutTests/inspector/performance/show-panel-network.html:27 > + WebInspector.showPanel("console");
console is animating, choose audits over it.
> LayoutTests/platform/chromium/test_expectations.txt:582 > +WONTFIX SKIP : inspector/performance = TEXT TIMEOUT
If you put the test to under inspector/performance/resources, they won't run automatically.
> Source/WebCore/inspector/front-end/ElementsPanel.js:300 > + WebInspector.setCurrentPanel(this);
I'd suggest that you land this change separately + convert currentPanel getter to a function (currentPanel()).
Ilya Tikhonovsky
Comment 3
2011-09-16 05:51:49 PDT
Created
attachment 107641
[details]
[patch] initial version
Pavel Feldman
Comment 4
2011-09-16 06:55:48 PDT
Comment on
attachment 107641
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=107641&action=review
> LayoutTests/inspector/performance/resources/show-panel-network.html:29 > + timer.finish(timerCookie);
Either you should use cookie to refer to timer or you should make finish mark test as completed.
Ilya Tikhonovsky
Comment 5
2011-09-16 07:10:56 PDT
Created
attachment 107645
[details]
[patch] third version
Pavel Feldman
Comment 6
2011-09-16 08:48:43 PDT
Comment on
attachment 107645
[details]
[patch] third version View in context:
https://bugs.webkit.org/attachment.cgi?id=107645&action=review
> LayoutTests/inspector/performance/resources/performance-test.js:10 > + this._testStartTime = new Date().valueOf();
no need for valueOf
> LayoutTests/inspector/performance/resources/performance-test.js:29 > + var time = new Date().valueOf();
ditto
> LayoutTests/inspector/performance/resources/performance-test.js:44 > + setTimeout(this._runTest.bind(this), 0);
You should queue execution instead.
> LayoutTests/inspector/performance/resources/performance-test.js:59 > + samples.sort( function(a, b) { return a - b; });
erroneous " " between ( and function
Ilya Tikhonovsky
Comment 7
2011-09-16 09:25:49 PDT
Committed
r95296
: <
http://trac.webkit.org/changeset/95296
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug