Bug 68223 - [Qt] Crash when dragging google maps.
Summary: [Qt] Crash when dragging google maps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL: http://maps.google.com
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 22:42 PDT by Leo Yang
Modified: 2011-09-16 04:35 PDT (History)
0 users

See Also:


Attachments
Patch (4.96 KB, patch)
2011-09-15 22:57 PDT, Leo Yang
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2011-09-15 22:42:23 PDT
Use QtTestBrowser

1. Load http://maps.google.com.
2. Drag the map.

It's very likely to crash.
Comment 1 Leo Yang 2011-09-15 22:57:23 PDT
Created attachment 107605 [details]
Patch
Comment 2 Adam Barth 2011-09-15 23:43:25 PDT
Comment on attachment 107605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review

> Source/WebCore/platform/qt/CursorQt.cpp:203
> +            m_platformCursor = new QCursor(Qt::ArrowCursor);

m_platformCursor isn't any sort of smart pointer?
Comment 3 Leo Yang 2011-09-16 00:15:18 PDT
Committed r95275: <http://trac.webkit.org/changeset/95275>
Comment 4 Alexis Menard (darktears) 2011-09-16 04:35:06 PDT
Comment on attachment 107605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review

>> Source/WebCore/platform/qt/CursorQt.cpp:203
>> +            m_platformCursor = new QCursor(Qt::ArrowCursor);
> 
> m_platformCursor isn't any sort of smart pointer?

It's deleted in the destructor but yes could be an improvement. Though it is define as mutable PlatformCursor m_platformCursor; for every port except Mac where it is : mutable RetainPtr<NSCursor> m_platformCursor; Definitively some improvements possible here.