Bug 68218 - currentColor not supported in box-shadow and text-shadow
Summary: currentColor not supported in box-shadow and text-shadow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Barr
URL: http://jsfiddle.net/leaverou/4vUMM/show
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 20:48 PDT by Lea Verou
Modified: 2011-10-07 09:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.21 KB, patch)
2011-10-06 17:56 PDT, David Barr
no flags Details | Formatted Diff | Diff
Patch (8.19 KB, patch)
2011-10-06 22:47 PDT, David Barr
no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2011-10-07 00:12 PDT, David Barr
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lea Verou 2011-09-15 20:48:55 PDT
As the title mentions, Webkit seems to drop currentColor in both text-shadow and box-shadow. If you replace currentColor with red in the testcase, it works fine.
Comment 1 Alexey Proskuryakov 2011-09-16 00:38:02 PDT
Not sure how closely it's related, but see also: bug 58730.
Comment 2 Simon Fraser (smfr) 2011-09-16 08:43:02 PDT
I hate currentColor :(
Comment 3 David Barr 2011-10-05 20:45:51 PDT
Confirmed on Webkit r96763 and Chrome 16.0.901.0 canary.
Comment 4 David Barr 2011-10-06 17:56:58 PDT
Created attachment 110069 [details]
Patch
Comment 5 David Barr 2011-10-06 17:58:01 PDT
Comment on attachment 110069 [details]
Patch

This was a surprisingly straightforward fix. Pixel test included.
Comment 6 WebKit Review Bot 2011-10-06 22:05:25 PDT
Comment on attachment 110069 [details]
Patch

Attachment 110069 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10000089

New failing tests:
fast/box-shadow/box-shadow-currentcolor.html
Comment 7 David Barr 2011-10-06 22:42:45 PDT
Comment on attachment 110069 [details]
Patch

Work around flakiness of ews-linux bot, particularly linux-xvfb.
Comment 8 David Barr 2011-10-06 22:47:05 PDT
Created attachment 110091 [details]
Patch
Comment 9 David Barr 2011-10-06 22:49:14 PDT
Comment on attachment 110091 [details]
Patch

chromium-linux bots are green at this time, hopefully no cq- for me.
Comment 10 Simon Fraser (smfr) 2011-10-06 23:01:03 PDT
Comment on attachment 110091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110091&action=review

> LayoutTests/fast/box-shadow/box-shadow-currentcolor.html:9
> +      box-shadow: 0 10px 20px red;

It would be better to use a box-shadow with a big spread and no blur, to avoid platform differences in blurring code.
Comment 11 WebKit Review Bot 2011-10-06 23:12:44 PDT
Comment on attachment 110091 [details]
Patch

Attachment 110091 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10007120

New failing tests:
fast/box-shadow/box-shadow-currentcolor.html
Comment 12 David Barr 2011-10-07 00:12:07 PDT
Created attachment 110098 [details]
Patch
Comment 13 David Barr 2011-10-07 00:13:09 PDT
Comment on attachment 110098 [details]
Patch

Updated patch to use solid shadow to avoid platform differences.
Comment 14 WebKit Review Bot 2011-10-07 09:59:50 PDT
Comment on attachment 110098 [details]
Patch

Clearing flags on attachment: 110098

Committed r96952: <http://trac.webkit.org/changeset/96952>
Comment 15 WebKit Review Bot 2011-10-07 09:59:55 PDT
All reviewed patches have been landed.  Closing bug.