Bug 68216 - remove un-necessary data members in LiteralParser::Lex
Summary: remove un-necessary data members in LiteralParser::Lex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 20:21 PDT by Charles Wei
Modified: 2011-12-22 03:56 PST (History)
2 users (show)

See Also:

Attachments
Patch (115.93 KB, patch)
2011-09-15 20:33 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2011-09-15 20:57 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch for landing (1.28 KB, patch)
2011-12-21 19:19 PST, Leo Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2011-09-15 20:21:59 PDT 
The m_string of LiteralParser::Lex is not used and should be removed.
Comment 1 Charles Wei 2011-09-15 20:33:28 PDT 
Created attachment 107594 [details]
Patch
Comment 2 Charles Wei 2011-09-15 20:57:49 PDT 
Created attachment 107599 [details]
Patch
Comment 3 WebKit Review Bot 2011-12-21 15:29:21 PST 
Comment on attachment 107599 [details]
Patch

Rejecting attachment 107599 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
svn-apply', u'--reviewer', u'George Staikos', u'--f..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/runtime/LiteralParser.h
Hunk #1 FAILED at 130.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/LiteralParser.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'George Staikos', u'--f..." exit_code: 1

Full output: http://queues.webkit.org/results/11000147
Comment 4 Leo Yang 2011-12-21 19:19:16 PST 
Created attachment 120258 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-12-22 03:56:47 PST 
Comment on attachment 120258 [details]
Patch for landing

Clearing flags on attachment: 120258

Committed r103522: <http://trac.webkit.org/changeset/103522>
Comment 6 WebKit Review Bot 2011-12-22 03:56:51 PST 
All reviewed patches have been landed.  Closing bug.