WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68216
remove un-necessary data members in LiteralParser::Lex
https://bugs.webkit.org/show_bug.cgi?id=68216
Summary
remove un-necessary data members in LiteralParser::Lex
Charles Wei
Reported
2011-09-15 20:21:59 PDT
The m_string of LiteralParser::Lex is not used and should be removed.
Attachments
Patch
(115.93 KB, patch)
2011-09-15 20:33 PDT
,
Charles Wei
no flags
Details
Formatted Diff
Diff
Patch
(1.25 KB, patch)
2011-09-15 20:57 PDT
,
Charles Wei
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.28 KB, patch)
2011-12-21 19:19 PST
,
Leo Yang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Charles Wei
Comment 1
2011-09-15 20:33:28 PDT
Created
attachment 107594
[details]
Patch
Charles Wei
Comment 2
2011-09-15 20:57:49 PDT
Created
attachment 107599
[details]
Patch
WebKit Review Bot
Comment 3
2011-12-21 15:29:21 PST
Comment on
attachment 107599
[details]
Patch Rejecting
attachment 107599
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: svn-apply', u'--reviewer', u'George Staikos', u'--f..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/runtime/LiteralParser.h Hunk #1 FAILED at 130. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/LiteralParser.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'George Staikos', u'--f..." exit_code: 1 Full output:
http://queues.webkit.org/results/11000147
Leo Yang
Comment 4
2011-12-21 19:19:16 PST
Created
attachment 120258
[details]
Patch for landing
WebKit Review Bot
Comment 5
2011-12-22 03:56:47 PST
Comment on
attachment 120258
[details]
Patch for landing Clearing flags on attachment: 120258 Committed
r103522
: <
http://trac.webkit.org/changeset/103522
>
WebKit Review Bot
Comment 6
2011-12-22 03:56:51 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug