Bug 68215 - DFG JIT does not optimize method_check
Summary: DFG JIT does not optimize method_check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 20:08 PDT by Filip Pizlo
Modified: 2011-09-15 23:34 PDT (History)
1 user (show)

See Also:


Attachments
the patch (37.81 KB, patch)
2011-09-15 20:14 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch - fix style (40.50 KB, patch)
2011-09-15 20:21 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-15 20:08:58 PDT
The DFG JIT emits a lot of code for method_check even though it has a plethora of profiling information that it could use (both from the meta-data in MethodCallLinkInfo and ValueProfile's) to determine how to optimize method_check down to a small number of instructions.
Comment 1 Filip Pizlo 2011-09-15 20:14:46 PDT
Created attachment 107590 [details]
the patch
Comment 2 WebKit Review Bot 2011-09-15 20:17:44 PDT
Attachment 107590 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:53:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:239:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-09-15 20:21:17 PDT
Created attachment 107592 [details]
the patch - fix style
Comment 4 Filip Pizlo 2011-09-15 23:34:22 PDT
Landed in r95273.