WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68188
Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188
Summary
Remove ScrollView::platformContentsSize
Anders Carlsson
Reported
2011-09-15 13:41:42 PDT
Remove ScrollView::platformContentsSize
Attachments
Patch
(3.67 KB, patch)
2011-09-15 13:43 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(5.20 KB, patch)
2011-09-20 13:10 PDT
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-09-15 13:43:51 PDT
Created
attachment 107544
[details]
Patch
Anders Carlsson
Comment 2
2011-09-15 14:09:23 PDT
Committed
r95227
: <
http://trac.webkit.org/changeset/95227
>
Simon Fraser (smfr)
Comment 3
2011-09-15 18:02:20 PDT
This seems to have caused a lot of new test failures, see
http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r95228%20(2173)/results.html
Anders Carlsson
Comment 4
2011-09-19 16:40:59 PDT
Reopening this since the patch broke a bunch of tests and had to be rolled out
Anders Carlsson
Comment 5
2011-09-20 13:10:24 PDT
Created
attachment 108043
[details]
Patch
Darin Adler
Comment 6
2011-09-20 13:11:28 PDT
Comment on
attachment 108043
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=108043&action=review
Need to be sure to do more testing this time!
> Source/WebKit/mac/WebView/WebFrameView.mm:170 > - documentView = [[viewClass alloc] initWithFrame:[self bounds]]; > + documentView = [[viewClass alloc] initWithFrame:NSZeroRect];
Just calling the init method will do the same thing. I think that’s more elegant than passing NSZeroRect.
Anders Carlsson
Comment 7
2011-09-20 14:46:05 PDT
Committed
r95570
: <
http://trac.webkit.org/changeset/95570
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug