Bug 68188 - Remove ScrollView::platformContentsSize
Summary: Remove ScrollView::platformContentsSize
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on: 68262
  Show dependency treegraph
Reported: 2011-09-15 13:41 PDT by Anders Carlsson
Modified: 2011-09-20 14:46 PDT (History)
1 user (show)

See Also:

Patch (3.67 KB, patch)
2011-09-15 13:43 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (5.20 KB, patch)
2011-09-20 13:10 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-09-15 13:41:42 PDT
Remove ScrollView::platformContentsSize
Comment 1 Anders Carlsson 2011-09-15 13:43:51 PDT
Created attachment 107544 [details]
Comment 2 Anders Carlsson 2011-09-15 14:09:23 PDT
Committed r95227: <http://trac.webkit.org/changeset/95227>
Comment 3 Simon Fraser (smfr) 2011-09-15 18:02:20 PDT
This seems to have caused  a lot of new test failures, see
Comment 4 Anders Carlsson 2011-09-19 16:40:59 PDT
Reopening this since the patch broke a bunch of tests and had to be rolled out
Comment 5 Anders Carlsson 2011-09-20 13:10:24 PDT
Created attachment 108043 [details]
Comment 6 Darin Adler 2011-09-20 13:11:28 PDT
Comment on attachment 108043 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108043&action=review

Need to be sure to do more testing this time!

> Source/WebKit/mac/WebView/WebFrameView.mm:170
> -            documentView = [[viewClass alloc] initWithFrame:[self bounds]];
> +            documentView = [[viewClass alloc] initWithFrame:NSZeroRect];

Just calling the init method will do the same thing. I think that’s more elegant than passing NSZeroRect.
Comment 7 Anders Carlsson 2011-09-20 14:46:05 PDT
Committed r95570: <http://trac.webkit.org/changeset/95570>