RESOLVED FIXED Bug 68183
[Qt] QTouchWebView missing loadProgress tests 
https://bugs.webkit.org/show_bug.cgi?id=68183
Summary [Qt] QTouchWebView missing loadProgress tests
Gopal Raghavan
Reported 2011-09-15 12:59:37 PDT
There are no tests to check loadProgress property of TouchWebView
Attachments
TouchWebView loadProgress test (2.24 KB, patch)
2011-09-15 13:08 PDT, Gopal Raghavan 		no flags
DetailsFormatted DiffDiff
updated patch with reviewer comments (2.28 KB, patch)
2011-09-16 11:43 PDT, Gopal Raghavan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gopal Raghavan
Comment 1 2011-09-15 13:08:43 PDT
Created attachment 107535 [details] TouchWebView loadProgress test Added new tests to check loadProgress property of TouchWebView. Here are the test results: ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() QWARN : DesktopWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::test_url() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QWARN : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_load() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QWARN : TouchWebViewLoad::test_loadNegativeSizeView() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadNegativeSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoadProgress::initTestCase() QWARN : TouchWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoadProgress::test_loadProgress() PASS : TouchWebViewLoadProgress::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadZeroSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() QWARN : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::test_url() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 24 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* Number of leaked textures: 0 Number of leaked materials: 0 Number of leaked nodes: 0 LEAK: 7 WebContext Number of leaked items: 0
Alexis Menard (darktears)
Comment 2 2011-09-15 13:22:45 PDT
Comment on attachment 107535 [details] TouchWebView loadProgress test LGTM.
Chang Shu
Comment 3 2011-09-16 06:28:12 PDT
Comment on attachment 107535 [details] TouchWebView loadProgress test Looks good. But please cleanup the format of the qml file. I think there are tabs in it.
Gopal Raghavan
Comment 4 2011-09-16 11:43:28 PDT
Created attachment 107693 [details] updated patch with reviewer comments Chang, I have updated patch with format fixes. Thanks.
Chang Shu
Comment 5 2011-09-16 11:48:44 PDT
Comment on attachment 107693 [details] updated patch with reviewer comments Thanks!
WebKit Review Bot
Comment 6 2011-09-16 22:24:03 PDT
Comment on attachment 107693 [details] updated patch with reviewer comments Clearing flags on attachment: 107693 Committed r95367: <http://trac.webkit.org/changeset/95367>
WebKit Review Bot
Comment 7 2011-09-16 22:24:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.